Correct plural of arguments in format_args! #15785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this as well? |
| @@ -215,12 +215,21 @@ impl<'a, 'b> Context<'a, 'b> { | |||
| } | |||
| } | |||
|
|
|||
| fn describe_num_args(&self) -> String { | |||
| if self.args.len() == 1 { | |||
| "there is 1 argument".to_string() | |||
There was a problem hiding this comment.
before, this didn't allocate, but now it does, right?
I guess this doesn't matter with an error...
There was a problem hiding this comment.
That's right. I think the readability makes it worth it.
|
As for the tests, we want a file with: format!("{0} {1}", 1);
//^~ ERROR invalid reference to argument `1` (there is 1 argument)inside |
|
Yeah, you can also just add a test case to |
bors
added a commit
that referenced
this pull request
Jul 20, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
Initial support for implicit drop inlay hint cc rust-lang#15785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15780.