tutorial: rework nolink description to remove mention of "empty string" #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged. |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Downgrade let_unit_value to pedantic Given that the false positive in rust-lang#1502 is marked E-hard and I don't have much hope of it getting fixed, I think it would be wise to disable this lint by default. I have had to suppress this lint in every substantial codebase (\>100k line) I have worked in. Any time this lint is being triggered, it's always the false positive case. The motivation for this lint is documented as: > A unit value cannot usefully be used anywhere. So binding one is kind of pointless. with this example: > ```rust > let x = { > 1; > }; > ``` Sure, but the author would find this out via an unused_variable warning or from `x` not being the type that they need further down. If there ends up being a type error on `x`, clippy's advice isn't going to help get the code compiling because it can only run if the code already compiles. changelog: Remove let_unit_value from default set of enabled lints
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
Don't lint `let_unit_value` when needed for type inferenece fixes: rust-lang#1502 Pinging `@dtolnay.` I think this is enough to fix the issue. Do you have a good list crates to test this on? changelog: Don't lint `let_unit_value` when needed for type inference
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
* Fix some typos. Co-authored-by: pierwill <[email protected]>
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
* Fix some typos. Co-authored-by: pierwill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I replaced link_name="" with nolink in the tutorial, I left the sentence in an awkward state.