Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Stop calling error! in resolve #14239

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

These are taken care of with compiler errors later on, no need to spam with
extra unformatted information unconditionally.

Closes #14225

@huonw
Copy link
Member

huonw commented May 15, 2014

I'm not sure this should close #14225. It does fix the random junk but saying "Use of undeclared module Foo" when Foo is a defined & in-scope type seems bad.

(At the very least, a new bug should be opened about that.)

r=me in either case.

@alexcrichton
Copy link
Member Author

That may be covered by #7950 (which was opened by you as well!) aah, the age of 7k issues!

@huonw
Copy link
Member

huonw commented May 16, 2014

Hahaha, whoops.

bors added a commit that referenced this pull request May 16, 2014
These are taken care of with compiler errors later on, no need to spam with
extra unformatted information unconditionally.

Closes #14225
These are taken care of with compiler errors later on, no need to spam with
extra unformatted information unconditionally.

Closes rust-lang#14225
bors added a commit that referenced this pull request May 17, 2014
These are taken care of with compiler errors later on, no need to spam with
extra unformatted information unconditionally.

Closes #14225
@bors bors closed this May 17, 2014
@alexcrichton alexcrichton deleted the issue-14225 branch May 19, 2014 15:57
lnicola pushed a commit to lnicola/rust that referenced this pull request Mar 13, 2023
fix: Load the sysroot in all CLI commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling a static method on a type with no static methods results in "module wasn't actually a module!" error
3 participants