Update the standard library to Rust 2024 #138162

ehuss · 2025-03-07T14:09:33Z

This updates the standard library to Rust 2024. This includes the following notable changes:

Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

(Draft while I do some try jobs, as this is a high-risk of breakage.)

try-job: dist-powerpc64le-linux
try-job: i686-gnu-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: x86_64-msvc-1
try-job: x86_64-msvc-ext1
try-job: x86_64-msvc-ext3

rustbot · 2025-03-07T14:09:38Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ehuss · 2025-03-07T14:10:03Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android try-job: armhf-gnu try-job: dist-aarch64-apple try-job: dist-aarch64-linux try-job: dist-aarch64-msvc try-job: dist-android try-job: dist-apple-various try-job: dist-arm-linux try-job: dist-armhf-linux try-job: dist-armv7-linux try-job: dist-i586-gnu-i586-i686-musl try-job: dist-i686-linux try-job: dist-i686-mingw try-job: dist-i686-msvc try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-ohos try-job: dist-powerpc-linux

bors · 2025-03-07T14:11:15Z

⌛ Trying commit fab07c3 with merge a525bde...

bors · 2025-03-07T17:03:16Z

☀️ Try build successful - checks-actions
Build commit: a525bde (a525bde7d4aebdcc7c7ebf678404cbaf6245a0c2)

ehuss · 2025-03-07T23:51:55Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64-linux try-job: dist-powerpc64le-linux try-job: dist-riscv64-linux try-job: dist-s390x-linux try-job: dist-various-1 try-job: dist-various-2 try-job: dist-x86_64-apple try-job: dist-x86_64-freebsd try-job: dist-x86_64-illumos try-job: dist-x86_64-linux try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-musl try-job: dist-x86_64-netbsd try-job: i686-gnu-1 try-job: i686-gnu-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: i686-msvc-1

bors · 2025-03-07T23:53:06Z

⌛ Trying commit fab07c3 with merge d5db9948be8ef00a4525ae10add3f9f79e9c3d27...

bors · 2025-03-08T02:11:04Z

💔 Test failed - checks-actions

bors · 2025-03-08T16:35:05Z

☔ The latest upstream changes (presumably #138208) made this pull request unmergeable. Please resolve the merge conflicts.

ehuss · 2025-03-08T19:00:09Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: mingw-check try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: x86_64-fuchsia try-job: x86_64-gnu-distcheck try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3 try-job: x86_64-rust-for-linux

bors · 2025-03-08T19:02:22Z

⌛ Trying commit 39d5d92 with merge fc2f6df187740a61ca2241b22b3748ae663a2e2d...

bors · 2025-03-08T20:46:27Z

💔 Test failed - checks-actions

ehuss · 2025-03-08T21:22:49Z

@bors try

(weird random stack overflow in x86_64-mingw-1)

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-apple-1 try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3

bors · 2025-03-08T21:24:00Z

⌛ Trying commit 39d5d92 with merge 4758198d7efd16e1e2e77180e300780b6b3eb881...

bors · 2025-03-08T23:27:19Z

💔 Test failed - checks-actions

ehuss · 2025-03-09T01:53:56Z

Posted #138248 with the current blocker here.

hkBst · 2025-03-09T18:02:33Z

library/std/src/keyword_docs.rs

@@ -1064,7 +1064,7 @@ mod move_keyword {}
 /// ```rust,compile_fail,E0502
 /// let mut v = vec![0, 1];
 /// let mut_ref_v = &mut v;
-/// ##[allow(unused)]
+/// # #[allow(unused)]


What is this ## -> # #?

This is a workaround for #136899. Sorry, should have mentioned that in the description.

When migrating the standard library to 2024, there will be some behavior changes that users will be able to observe. This test should cover that (I cannot think of any other observable differences).

ehuss · 2025-03-10T21:53:10Z

@bors try

bors · 2025-03-10T21:54:22Z

⌛ Trying commit 06375b3 with merge ee3f9ef...

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext3

scottmcm · 2025-03-11T00:01:03Z

...y/combine_clone_of_primitives.{impl#0}-clone.InstSimplify-after-simplifycfg.panic-abort.diff

-          StorageDead(_8);
-          StorageDead(_5);
-          StorageDead(_2);
          StorageDead(_10);
+          StorageDead(_8);
          StorageDead(_7);
+          StorageDead(_5);
          StorageDead(_4);
+          StorageDead(_2);


This is obviously not the main point of e2024, but it's fun to see that these just end up in decreasing order now. It obviously doesn't actually matter, but it's a nice indication that how the temporaries are getting cleaned up really is in a more reasonable order.

bors · 2025-03-11T00:07:14Z

💔 Test failed - checks-actions

ehuss · 2025-03-11T00:27:55Z

@bors try

bors · 2025-03-11T00:29:05Z

⌛ Trying commit 0b5c62e with merge aeb900d...

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: x86_64-msvc-1 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext3

rustbot assigned BoxyUwU Mar 7, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025

ehuss force-pushed the library-2024 branch 2 times, most recently from 2df2508 to 39d5d92 Compare March 8, 2025 18:55

rustbot added the O-windows Operating system: Windows label Mar 8, 2025

This comment has been minimized.

Sign in to view

ehuss mentioned this pull request Mar 9, 2025

Stack overflow on large doctests in edition 2024 on Windows #138248

Closed

hkBst reviewed Mar 9, 2025

View reviewed changes

ehuss added 6 commits March 10, 2025 14:51

Add a test for new 2024 standard library behavior

4361328

When migrating the standard library to 2024, there will be some behavior changes that users will be able to observe. This test should cover that (I cannot think of any other observable differences).

Migrate core to Rust 2024

b990f8f

Migrate alloc to Rust 2024

cdf6732

Migrate panic_abort to Rust 2024

4bf87af

Migrate panic_unwind to Rust 2024

b41ab24

Migrate unwind to Rust 2024

f6794dc

ehuss force-pushed the library-2024 branch from 39d5d92 to 06375b3 Compare March 10, 2025 21:51

scottmcm reviewed Mar 11, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

ehuss force-pushed the library-2024 branch from 06375b3 to 0b5c62e Compare March 11, 2025 00:26

ehuss added 7 commits March 10, 2025 17:27

Migrate std to Rust 2024

b904853

Migrate test to Rust 2024

024d6e0

Migrate proc_macro to Rust 2024

b307024

Migrate profiler_builtins to Rust 2024

e6ec5c7

Migrated the rustc-std-workspace crates to Rust 2024

a414af6

Migrate the sysroot crate to Rust 2024

b09af59

Migrate windows-targets to Rust 2024

0b5c62e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the standard library to Rust 2024 #138162

Update the standard library to Rust 2024 #138162

ehuss commented Mar 7, 2025 •

edited

Loading

rustbot commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 8, 2025

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 9, 2025

hkBst Mar 9, 2025

ehuss Mar 10, 2025

ehuss commented Mar 10, 2025

bors commented Mar 10, 2025

scottmcm Mar 11, 2025

This comment has been minimized.

bors commented Mar 11, 2025

ehuss commented Mar 11, 2025

bors commented Mar 11, 2025

Update the standard library to Rust 2024 #138162

Are you sure you want to change the base?

Update the standard library to Rust 2024 #138162

Conversation

ehuss commented Mar 7, 2025 • edited Loading

rustbot commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 8, 2025

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 9, 2025

hkBst Mar 9, 2025

Choose a reason for hiding this comment

ehuss Mar 10, 2025

Choose a reason for hiding this comment

ehuss commented Mar 10, 2025

bors commented Mar 10, 2025

scottmcm Mar 11, 2025

Choose a reason for hiding this comment

This comment has been minimized.

bors commented Mar 11, 2025

ehuss commented Mar 11, 2025

bors commented Mar 11, 2025

ehuss commented Mar 7, 2025 •

edited

Loading