syntax: Make ViewItemUse no longer contain multiple view paths. #13777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it reflected the obsolete syntax `use a, b, c;` and did not make past the parser (though it was a non-fatal error so we can continue). this legacy affected many portions of rustc and rustdoc as well, so this commit cleans them up altogether.
it should be changed when the module gets updated, so it helps to have the `SCHEMA_VERSION` with the definitions themselves.
|
Caveat: While I believe this PR does not affect other crates (and the most important test cases do pass),
|
lifthrasiir
changed the title
This happened to me awhile back because I had an otherwise installed version of rust in my PATH, and the linkage was getting mismatched. I don't think this is your fault.
I had no idea any debuginfo tests passed on windows! |
bors
added a commit
that referenced
this pull request
Apr 26, 2014
…richton It reflected the obsolete syntax `use a, b, c;` and did not make past the parser (though it was a non-fatal error so we can continue). This legacy affected many portions of rustc and rustdoc as well, so this PR cleans them up altogether. As a side effect of cleanup, we now have `SCHEMA_VERSION` in `rustdoc::clean` (instead of the crate root), so it has a better chance to be updated when `rustdoc::clean` gets updated.
bors
added a commit
that referenced
this pull request
Apr 26, 2014
…richton It reflected the obsolete syntax `use a, b, c;` and did not make past the parser (though it was a non-fatal error so we can continue). This legacy affected many portions of rustc and rustdoc as well, so this PR cleans them up altogether. As a side effect of cleanup, we now have `SCHEMA_VERSION` in `rustdoc::clean` (instead of the crate root), so it has a better chance to be updated when `rustdoc::clean` gets updated.
bors
added a commit
that referenced
this pull request
Apr 27, 2014
…richton It reflected the obsolete syntax `use a, b, c;` and did not make past the parser (though it was a non-fatal error so we can continue). This legacy affected many portions of rustc and rustdoc as well, so this PR cleans them up altogether. As a side effect of cleanup, we now have `SCHEMA_VERSION` in `rustdoc::clean` (instead of the crate root), so it has a better chance to be updated when `rustdoc::clean` gets updated.
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
fix: add a check for `if` token in patterns parser Closes rust-lang#13776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reflected the obsolete syntax
use a, b, c;and did not make past the parser (though it was a non-fatal error so we can continue). This legacy affected many portions of rustc and rustdoc as well, so this PR cleans them up altogether.As a side effect of cleanup, we now have
SCHEMA_VERSIONinrustdoc::clean(instead of the crate root), so it has a better chance to be updated whenrustdoc::cleangets updated.