Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check code in unused_delims #137029

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Remove unnecessary check code in unused_delims #137029

merged 1 commit into from
Feb 15, 2025

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Feb 14, 2025 •
edited
Loading

After PR #108297, we make sure there is no unmatched delims in early lint check.

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2025
jieyouxu
jieyouxu approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 14, 2025

📌 Commit 34e7dc3 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned Noratrieb Feb 14, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
@compiler-errors
Copy link
Member

@bors r-

Could you just delete the comment altogether? Thanks.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2025
@chenyukang chenyukang force-pushed the yukang-fix-unused-check branch from 34e7dc3 to b2197ab Compare February 14, 2025 23:35
@chenyukang
Copy link
Member Author

@bors r=jieyouxu,compiler-errors

@bors
Copy link
Contributor

bors commented Feb 14, 2025

📌 Commit b2197ab has been approved by jieyouxu,compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 14, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2025
@jhpratt jhpratt mentioned this pull request Feb 15, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
@bors
Auto merge of rust-lang#137065 - jhpratt:rollup-ree9mej, r=jhpratt
8c07d14 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136749 (Implement Extend<AsciiChar> for String)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136978 (Windows: Update generated bindings)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137029 (Remove unnecessary check code in unused_delims)
 - rust-lang#137056 (made check_argument_compat public for use in miri)
 - rust-lang#137062 (Forward all default methods for I/O impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 221ba2d into rust-lang:master Feb 15, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
@rust-timer
Unrolled build for rust-lang#137029
d450a6e 
Rollup merge of rust-lang#137029 - chenyukang:yukang-fix-unused-check, r=jieyouxu,compiler-errors

Remove unnecessary check code in unused_delims

After PR rust-lang#108297, we make sure there is no unmatched delims in early lint check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors requested changes

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chenyukang @rustbot @jieyouxu @bors @compiler-errors @Noratrieb