-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" #136582
Conversation
This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185
This comment was marked as off-topic.
This comment was marked as off-topic.
r? @tgross35 |
@bors try |
Fyi @rust-lang/infra |
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
|
@bors try |
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
☀️ Try build successful - checks-actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but infra should probably take a look
r? infra
Jakub took a look via Zulip r? tgross35 |
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136592 (Make sure we don't overrun the stack in canonicalizer) - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#136582 - asomers:revert-132232, r=tgross35 Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
This reverts commit cf34545.
That commit led to a regression of
#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause.
Fixes #132185
try-job: dist-x86_64-freebsd
try-job: dist-various-2