New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: feature gates errors should use the new attribute syntax #13652

Merged

bors merged 1 commit into rust-lang:master from erickt:master

Apr 21, 2014

Contributor

erickt commented Apr 21, 2014

No description provided.


          rustc: feature gates errors should use the new attribute syntax

2df7601

bors added a commit that referenced this pull request


          auto merge of #13652 : erickt/rust/master, r=alexcrichton

1c101da

bors closed this

bors merged commit 2df7601 into rust-lang:master

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#13652 - jhgg:hir-expand/fix-compile-error-exp…

76e2e41

…ansion, r=Veykril

hir-expand: fix compile_error! expansion not unquoting strings

expanding `compile_error!` would not properly unquote strings, leading to quite ugly diagnostic messages:

![image](https://user-images.githubusercontent.com/5489149/202893481-2486ede8-c79a-4972-9713-416d6a704064.png)

this fixes it, using the conveniently placed `unquote_str` function, which now makes errors look like:

![image](https://user-images.githubusercontent.com/5489149/202893466-0763efad-9240-4d55-80a6-6c62000d5d2b.png)

additionally, using `unquote_str` has the cool side-effect of *also* handling raw strings, so this fixes a fixme too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet