Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UnsafeCell direct access APIs #136398

Merged
merged 1 commit into from
Feb 4, 2025
Merged

add UnsafeCell direct access APIs #136398

merged 1 commit into from
Feb 4, 2025

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Feb 1, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 1, 2025
@pitaj pitaj mentioned this pull request Jan 31, 2025
Open
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pitaj pitaj force-pushed the unsafecell_access branch from fe90428 to 670d892 Compare February 1, 2025 20:35
@joboet
Copy link
Member

joboet commented Feb 2, 2025

r? libs-api

The change from get to as should be approved by someone from T-libs-api.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 2, 2025
@rustbot rustbot assigned dtolnay and unassigned joboet Feb 2, 2025
dtolnay
dtolnay approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Feb 4, 2025

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2025

📌 Commit 670d892 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025
@jhpratt jhpratt mentioned this pull request Feb 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
@bors
Auto merge of rust-lang#136534 - jhpratt:rollup-dnz57dq, r=jhpratt
01e4f19 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#136398 (add UnsafeCell direct access APIs)
 - rust-lang#136465 (Some `rustc_middle` cleanups)
 - rust-lang#136479 (std::fs: further simplify dirent64 handling)
 - rust-lang#136504 (Fix last compare-mode false negatives in tests)
 - rust-lang#136511 (Add `cast_signed` and `cast_unsigned` methods for `NonZero` types)
 - rust-lang#136518 (Add note about `FnPtr` trait being exposed as public bound)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d89e98d into rust-lang:master Feb 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
@rust-timer
Unrolled build for rust-lang#136398
5f01710 
Rollup merge of rust-lang#136398 - pitaj:unsafecell_access, r=dtolnay

add UnsafeCell direct access APIs

- Implementation for ACP: rust-lang/libs-team#521
- Tracking issue rust-lang#136327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

@Sky9x Sky9x Sky9x approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pitaj @rustbot @rust-log-analyzer @joboet @dtolnay @bors @Sky9x