rustfmt: revert overflow_delimited_expr=true default in style_edition=2024
#136317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion=2024` There are still a few issues with `overflow_delimited_expr` where the option produces strange formatting. `overflow_delimited_expr` is still an unstable rustfmt configuration option, and after some discussion the consensus was to revert the `overflow_delimited_expr` change for style_edition 2024.
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
|
Closing in favor of #136312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136224
There are still a few issues with
overflow_delimited_exprwhere the option produces strange formatting.overflow_delimited_expris still an unstable rustfmt configuration option, and after some discussion the consensus was to revert theoverflow_delimited_exprchange for style_edition 2024.Zulip chat