Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Sizedness of return type in WF #136274

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Check Sizedness of return type in WF #136274

merged 3 commits into from
Feb 4, 2025

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 30, 2025 •
edited
Loading

Still need to clean this up a bit. This should fix rust-lang/trait-system-refactor-initiative#150.

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2025
compiler-errors
compiler-errors commented Jan 30, 2025
View reviewed changes
compiler/rustc_hir_typeck/src/check.rs Show resolved Hide resolved
compiler/rustc_hir_typeck/src/lib.rs Show resolved Hide resolved
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Show resolved Hide resolved
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Show resolved Hide resolved
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Show resolved Hide resolved
tests/ui/impl-trait/dyn-incompatible-trait-in-return-position-dyn-trait.stderr Outdated Show resolved Hide resolved
tests/ui/traits/negative-bounds/opaque-type-unsatisfied-bound.stderr Show resolved Hide resolved
tests/ui/traits/negative-bounds/opaque-type-unsatisfied-fn-bound.rs Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nit

compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Feb 1, 2025

☔ The latest upstream changes (presumably #136350) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors compiler-errors marked this pull request as ready for review February 2, 2025 15:03
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing CI/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Feb 4, 2025
@lcnr
Copy link
Contributor

lcnr commented Feb 4, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 4, 2025

📌 Commit 3683975 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
@bors
Auto merge of rust-lang#136549 - matthiaskrgr:rollup-sqbpgtd, r=matth…
bef3c3b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136242 (Remove `LateContext::match_def_path()`)
 - rust-lang#136274 (Check Sizedness of return type in WF)
 - rust-lang#136284 (Allow using named consts in pattern types)
 - rust-lang#136477 (Fix a couple NLL TLS spans )
 - rust-lang#136497 (Report generic mismatches when calling bodyless trait functions)
 - rust-lang#136520 (Remove unnecessary layout assertions for object-safe receivers)
 - rust-lang#136526 (mir_build: Rename `thir::cx::Cx` to `ThirBuildCx` and remove `UserAnnotatedTyHelpers`)

Failed merges:

 - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a8ecb79 into rust-lang:master Feb 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
@rust-timer
Unrolled build for rust-lang#136274
8b1d51f 
Rollup merge of rust-lang#136274 - compiler-errors:sized-wf, r=lcnr

Check Sizedness of return type in WF

Still need to clean this up a bit. This should fix rust-lang/trait-system-refactor-initiative#150.

r? lcnr
@compiler-errors
Copy link
Member Author

@rust-timer build 8b1d51f

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8b1d51f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 0.2% [0.1%, 0.2%] 2
Regressions ❌
(secondary)		 0.3% [0.2%, 0.3%] 7
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.2%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.3%, 0.2%] 7

Max RSS (memory usage)

Results (primary 1.2%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.5% [1.7%, 3.2%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) 1.2% [-1.2%, 3.2%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.717s -> 777.349s (-0.18%)
Artifact size: 328.88 MiB -> 328.82 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
A-rustdoc-json Area: Rustdoc JSON backend perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

return type sized check occurs in opaque defining env
6 participants
@compiler-errors @rust-log-analyzer @bors @lcnr @rust-timer @rustbot