Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfg_match] Library edition #136261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c410-f3r
Copy link
Contributor

#115585

Starts the usage of the cfg_match macro in the standard library.

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 29, 2025
@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 836b137 to dcd50b6 Compare January 29, 2025 19:47
@rust-log-analyzer

This comment has been minimized.

@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from dcd50b6 to 26383a6 Compare January 29, 2025 19:59
@rust-log-analyzer

This comment has been minimized.

@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 26383a6 to 401cc9e Compare January 29, 2025 20:19
@rust-log-analyzer

This comment has been minimized.

@c410-f3r c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 401cc9e to 38376b2 Compare January 29, 2025 20:39
@c410-f3r
Copy link
Contributor Author

r? T-libs

@rustbot rustbot assigned jhpratt and unassigned Noratrieb Jan 30, 2025
@tgross35
Copy link
Contributor

For reference, beta branch is in two weeks, at which point the complexity with bootstrap wouldn't be needed.

@ChrisDenton
Copy link
Member

Yes, I think we should wait at least until then. Though I'm also concerned that cfg_match is still undergoing changes which could cause more churn in the future. I think we should shy away from using unstable features in std until it's nearing stabilization because of the added complexity of doing so.

@jhpratt
Copy link
Member

jhpratt commented Jan 31, 2025

I'm inclined to wait until after bootstrap as well. I don't know the status of cfg_match well enough to make a statement on that. I'll defer to whoever wants to make that decision; feel free to claim the PR for yourself. If no one does post-bootstrap, I'll simply reassign.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Jan 31, 2025

#116342 was closed due to the possibility of future modifications but now with #133720 no further breaking changes are expected.

Moreover, the internal use of this feature is intended to assert the robustness of the implementation to ensure a smooth stabilization process, which has always been the case with a multitude of other unstable features.

@ChrisDenton
Copy link
Member

Experimenting with new features in the compiler is indeed very much encouraged! But less so for std. Indeed there's an effort to reduce the nightly features std uses. E.g. #94970 and #94971

Personally I'm ok with some experimentation but I would prefer that changes bake in nightly for a bit before risking churn in std.

@bors
Copy link
Contributor

bors commented Feb 4, 2025

☔ The latest upstream changes (presumably #136533) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants