-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cfg_match] Library edition #136261
base: master
Are you sure you want to change the base?
[cfg_match] Library edition #136261
Conversation
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
836b137
to
dcd50b6
Compare
This comment has been minimized.
This comment has been minimized.
dcd50b6
to
26383a6
Compare
This comment has been minimized.
This comment has been minimized.
26383a6
to
401cc9e
Compare
This comment has been minimized.
This comment has been minimized.
401cc9e
to
38376b2
Compare
r? T-libs |
For reference, beta branch is in two weeks, at which point the complexity with bootstrap wouldn't be needed. |
Yes, I think we should wait at least until then. Though I'm also concerned that |
I'm inclined to wait until after bootstrap as well. I don't know the status of |
#116342 was closed due to the possibility of future modifications but now with #133720 no further breaking changes are expected. Moreover, the internal use of this feature is intended to assert the robustness of the implementation to ensure a smooth stabilization process, which has always been the case with a multitude of other unstable features. |
Experimenting with new features in the compiler is indeed very much encouraged! But less so for std. Indeed there's an effort to reduce the nightly features std uses. E.g. #94970 and #94971 Personally I'm ok with some experimentation but I would prefer that changes bake in nightly for a bit before risking churn in std. |
☔ The latest upstream changes (presumably #136533) made this pull request unmergeable. Please resolve the merge conflicts. |
#115585
Starts the usage of the
cfg_match
macro in the standard library.