Disable some incorrect rust-analyzer diagnostics on beta #136236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rustbot label +beta-accepted |
rustbot
added
the
beta-accepted
|
OK -- I'll roll this in with other backports, probably tomorrow. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2025
[beta-1.85] backports * [Add `AsyncFn*` to `core` prelude](rust-lang#135852) * [Disable `overflow_delimited_expr` in edition 2024](rust-lang#136312) * [Disable some incorrect rust-analyzer diagnostics on beta](rust-lang#136236) * [fix: Fix #[rustc_deprecated_safe_2024]](rust-lang/rust-analyzer#19044) * [fix: Fix a bug where enum variants were not considered properly in type ns resolution](rust-lang/rust-analyzer#18976) * Update edition-guide * [Add alternatives for static-mut-refs](rust-lang/edition-guide#354) * [Remove rustfmt-overflow-delimited-expr](rust-lang/edition-guide#357)
|
Closing as merged by #136391. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust-analyzer#19044 and rust-lang/rust-analyzer#18976 both need backporting, but their diffs don't apply cleanly. So instead I opted for disabling one of the problematic diagnostics as well as unconditionally treating
rustc_deprecated_safe_2024items to be safe for now.r? @cuviper