Match Ergonomics 2024: update old-edition behavior of feature gates #136093
+1,821
−501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
dianne
force-pushed
the
match-2024-for-edition-2021
branch
2 times, most recently
from
737d409 to
d37a4d4
Compare
This also adds `#[cfg]` attributes to tests for bindings' types, to make it visually clearer which revisions type successfully.
These are superseded by the old-edition revisions on the shared tests.
dianne
force-pushed
the
match-2024-for-edition-2021
branch
from
d37a4d4 to
29626d0
Compare
|
This should now be ready for review, I think! r? @Nadrieril |
My reasoning: the ruleset implemented by the same feature gate in Edition 2024 always tries to eat the inherited reference first. For consistency, it makes sense to me to say across all editions that users should consider the inherited reference's mutability when wondering if a `&mut` pattern will type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the behavior of the feature gates
ref_pat_eat_one_layer_2024_structuralandref_pat_eat_one_layer_2024in Editions 2021 and earlier to correspond to the left and right typing rules compared here, respectively. Compared to thestable_rustrules:&patterns to eat&mutreference types (and lone&mutinherited refs) as if they're shared,&mutpatterns to eat&reference types when there's a&mutinherited reference to also eat,I think there's already tests for all of those typing rules, so I've added revisions to use the existing tests with the new rulesets. Additionally, I've added a few tests to make sure we handle mixed-edition patterns appropriately, and I've added references to the unstable book.
Relevant tracking issue: #123076
r? @ghost