Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable kernel sanitizers for aarch64-unknown-none-softfloat #135905

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Enable kernel sanitizers for aarch64-unknown-none-softfloat #135905

merged 1 commit into from
Jan 24, 2025

Conversation

workingjubilee
Copy link
Member

We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use.

cc @rcvalle @ojeda @maurer

@workingjubilee
Enable kernel sanitizers for aarch64-unknown-none-softfloat
6b06aa6 
We want kernels to be able to use this bare metal target, so
let's enable the sanitizers that kernels want to use.
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rcvalle
Copy link
Member

rcvalle commented Jan 22, 2025

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit 6b06aa6 has been approved by rcvalle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 23, 2025
@jhpratt
Rollup merge of rust-lang#135905 - workingjubilee:softly-sanitize-aar…
30177b8 
…ch64-floats, r=rcvalle

Enable kernel sanitizers for aarch64-unknown-none-softfloat

We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use.

cc `@rcvalle` `@ojeda` `@maurer`
@jhpratt jhpratt mentioned this pull request Jan 23, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135917 - jhpratt:rollup-onqgl3k, r=jhpratt
26e039f 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#133138 (Target modifiers (special marked options) are recorded in metainfo)
 - rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
 - rust-lang#135366 (Enable `unreachable_pub` lint in `test` and `proc_macro` crates)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
 - rust-lang#135855 (Only assert the `Parser` size on specific arches)
 - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
 - rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#135905 - workingjubilee:softly-sanitize-aar…
5e90f11 
…ch64-floats, r=rcvalle

Enable kernel sanitizers for aarch64-unknown-none-softfloat

We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use.

cc ``@rcvalle`` ``@ojeda`` ``@maurer``
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2025
Closed
@ojeda ojeda mentioned this pull request Jan 23, 2025
Open
53 tasks
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135925 - matthiaskrgr:rollup-5dlaatt, r=jieyouxu
f6d520f 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
 - rust-lang#135366 (Enable `unreachable_pub` lint in `test` and `proc_macro` crates)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
 - rust-lang#135855 (Only assert the `Parser` size on specific arches)
 - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
 - rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2025
@bors
Auto merge of rust-lang#135925 - matthiaskrgr:rollup-5dlaatt, r=jieyouxu
c353c12 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
 - rust-lang#135366 (Enable `unreachable_pub` lint in `test` and `proc_macro` crates)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
 - rust-lang#135855 (Only assert the `Parser` size on specific arches)
 - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
 - rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#135959 - matthiaskrgr:rollup-0jenyfw, r=matth…
48ef38d 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135366 (Enable `unreachable_pub` lint in `test` and `proc_macro` crates)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
 - rust-lang#135855 (Only assert the `Parser` size on specific arches)
 - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
 - rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b3fcd56 into rust-lang:master Jan 24, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@rust-timer
Unrolled build for rust-lang#135905
0ef033f 
Rollup merge of rust-lang#135905 - workingjubilee:softly-sanitize-aarch64-floats, r=rcvalle

Enable kernel sanitizers for aarch64-unknown-none-softfloat

We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use.

cc ```@rcvalle``` ```@ojeda``` ```@maurer```
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
@workingjubilee workingjubilee deleted the softly-sanitize-aarch64-floats branch January 24, 2025 20:35
@Darksonn
Copy link
Contributor

Darksonn commented Feb 6, 2025

As discussed on zulip, can we beta nominate this?

@ojeda
Copy link
Contributor

ojeda commented Feb 6, 2025

Maybe we have permissions to do that ourselves... Let's see:

@rustbot beta-nominate compiler

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2025

Error: The feature nominate is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@tgross35
Copy link
Contributor

tgross35 commented Feb 6, 2025

@rustbot label +beta-nominated

(it's just the label, anyone can nominate :) )

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 6, 2025
@ojeda
Copy link
Contributor

ojeda commented Feb 6, 2025

Ah, thanks a lot Trevor!

@cuviper
Copy link
Member

cuviper commented Feb 6, 2025

Beta backport accepted as per compiler team on Zulip.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 6, 2025
@cuviper cuviper mentioned this pull request Feb 6, 2025
Merged
@cuviper cuviper modified the milestones: 1.86.0, 1.85.0 Feb 6, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 6, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
@bors
Auto merge of rust-lang#136650 - cuviper:beta-next, r=cuviper
3821385 
[beta] backports

- Ensure that we don't try to access fields on a non-struct pattern type rust-lang#135222
- Do not include GCC source code in source tarballs rust-lang#135658
- Temporarily bring back `Rvalue::Len` rust-lang#135709
- Add a couple of missing `ensure_sufficient_stacks` rust-lang#136352
- Enable kernel sanitizers for aarch64-unknown-none-softfloat rust-lang#135905

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
9 participants
@workingjubilee @rustbot @rcvalle @bors @Darksonn @ojeda @tgross35 @cuviper @estebank