Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of RunCompiler #135880

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Get rid of RunCompiler #135880

merged 4 commits into from
Jan 24, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 22, 2025

The various set_* methods that have been removed can be replaced by setting the respective fields in the Callbacks::config implementation. set_using_internal_features was often forgotten and it's equivalent is now done automatically.

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the misc_driver_refactors branch from ee7c1f4 to 571d10b Compare January 22, 2025 14:35
@oli-obk oli-obk assigned oli-obk and unassigned estebank Jan 22, 2025
@bjorn3 bjorn3 force-pushed the misc_driver_refactors branch from 0195352 to 9ac6cb3 Compare January 22, 2025 14:51
@oli-obk
Copy link
Contributor

oli-obk commented Jan 22, 2025

r=me with CI happy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the misc_driver_refactors branch from 9ac6cb3 to 703c745 Compare January 22, 2025 15:15
bjorn3 added 4 commits January 23, 2025 09:38
@bjorn3
Remove the need to manually call set_using_internal_features
4f9b9a4
@bjorn3
Remove set_make_codegen_backend and set_file_loader
974db1a 
They can both be set inside the config callback too.
@bjorn3
Remove RunCompiler
a77776c 
It has become nothing other than a wrapper around run_compiler.
@bjorn3
Remove outdated sentence
241f824
@bjorn3 bjorn3 force-pushed the misc_driver_refactors branch from 703c745 to 241f824 Compare January 23, 2025 09:39
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 23, 2025

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jan 23, 2025

📌 Commit 241f824 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#135947 - matthiaskrgr:rollup-k9jpfls, r=matth…
1c9837d 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135073 (Implement `ByteStr` and `ByteString` types)
 - rust-lang#135492 (Add missing check for async body when suggesting await on futures.)
 - rust-lang#135766 (handle global trait bounds defining assoc types)
 - rust-lang#135880 (Get rid of RunCompiler)
 - rust-lang#135908 (rustc_codegen_llvm: remove outdated asm-to-obj codegen note)
 - rust-lang#135911 (Allow `arena_cache` queries to return `Option<&'tcx T>`)
 - rust-lang#135920 (simplify parse_format::Parser::ws by using next_if)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d31ae7 into rust-lang:master Jan 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
@bjorn3 bjorn3 deleted the misc_driver_refactors branch January 24, 2025 06:34
@marxin
Copy link
Contributor

marxin commented Jan 25, 2025

@bjorn3 Please fix rustc-dev-guide:

error: Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/struct.RunCompiler.html
  ┌─ rustc-driver/intro.md:9:45
  │
9 │ The main entry point of [`rustc_driver`] is [`rustc_driver::RunCompiler`][rd_rc].
  │                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server returned 404 Not Found for https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/struct.RunCompiler.html

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 25, 2025

Already did so in this very PR: https://github.com/rust-lang/rust/pull/135880/files#diff-e412c0c41d4b151a96b0662e580fc5eea17f297fae5dee26793a27d55bc87200R9 It probably hasn't yet been synced to the rustc-dev-guide repo.

@marxin
Copy link
Contributor

marxin commented Jan 25, 2025

Oh, thanks! The current situation with the documentation is confusing :P Apparently the changes can happen in both repos (rust and rustc-dev-guide) and the changes are synchronized :)

smoelius added a commit to trailofbits/dylint that referenced this pull request Jan 27, 2025
@smoelius
Account for rust-lang/rust#135880
fb6b74d
smoelius added a commit to trailofbits/dylint that referenced this pull request Jan 27, 2025
@smoelius
Account for rust-lang/rust#135880
9af0935
github-merge-queue bot pushed a commit to trailofbits/dylint that referenced this pull request Jan 27, 2025
@smoelius
Account for rust-lang/rust#135880
8b5adfe
@Kobzol
Copy link
Contributor

Kobzol commented Jan 27, 2025 •
edited
Loading

Oh, thanks! The current situation with the documentation is confusing :P Apparently the changes can happen in both repos (rust and rustc-dev-guide) and the changes are synchronized :)

Indeed. We don't currently run the linkchecker in Rust's CI, which is something that should be fixed though (I have it in my TODO list, unless someone gets to it first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk oli-obk left review comments

@estebank estebank estebank left review comments

Assignees

@oli-obk oli-obk

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
9 participants
@bjorn3 @rustbot @rust-log-analyzer @oli-obk @bors @marxin @Kobzol @RalfJung @estebank