Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: Parses && as & & whenever appropriate. #13576

Merged
merged 1 commit into from
Apr 18, 2014

Conversation

lifthrasiir
Copy link
Contributor

Uses the same strategy as || and >>. Closes #11227.

@huonw
Copy link
Member

huonw commented Apr 17, 2014

❤️

(If you're feeling like being doubly-awesome, #13324 is similar.)

@lifthrasiir
Copy link
Contributor Author

@huonw Huh, that actually make me rethink about the entire strategy currently used with || and >>. Technically we can replace Parser::bump with Parser::expect plus a partial token handling, but we already have a heap of matches that cannot be easily refactored without replacing them with multiple conditionals which prevents the refactoring. Well, I'd leave this commit as is for now.

@brson
Copy link
Contributor

brson commented Apr 17, 2014

How amenable is this strategy of "undoing" what the lexer has already done to being adapted to a more "normal" grammar? I.e. it seems like this is a huge flaw in the lexer that this fixup is required.

bors added a commit that referenced this pull request Apr 18, 2014
Uses the same strategy as `||` and `>>`. Closes #11227.
@bors bors closed this Apr 18, 2014
@bors bors merged commit 676cd61 into rust-lang:master Apr 18, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
…ock, r=jonas-schievink

Suppress "Implement default members" inside contained items

Fixes rust-lang#13561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can double-ref (&&x) parsing be fixed?
5 participants