Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of using carrying_mul_add to write wider multiplication #135750

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add an example of using carrying_mul_add to write wider multiplication #135750

merged 1 commit into from
Jan 22, 2025
+31 −2

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Jan 20, 2025 •
edited
Loading

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find carrying_mul_add useful :)

cc #85532 @clarfonthey

@scottmcm
Add an example of using carrying_mul_add to write wider multiplication
b2b12ae 
Just the basic quadratic version that you wouldn't actually want for a true bigint, but it's nice and short so is useful as an example :)
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 20, 2025
@scottmcm scottmcm mentioned this pull request Jan 20, 2025
Open
10 tasks
@cuviper
Copy link
Member

cuviper commented Jan 21, 2025

LGTM!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 21, 2025

📌 Commit b2b12ae has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 21, 2025
@jhpratt
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper
09d2e48 
Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 `@clarfonthey`
@jhpratt jhpratt mentioned this pull request Jan 21, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 21, 2025
@jieyouxu
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper
54c9c0e 
Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 ``@clarfonthey``
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 21, 2025
@jieyouxu
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper
dbc4adb 
Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 ```@clarfonthey```
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
@bors
Auto merge of rust-lang#135825 - jieyouxu:rollup-bske4m7, r=jieyouxu
dfd5d41 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4)
 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135707 (Shorten linker output even more when `--verbose` is not present)
 - rust-lang#135750 (Add an example of using `carrying_mul_add` to write wider multiplication)
 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135793 (Ignore `mermaid.min.js`)
 - rust-lang#135810 (Add Kobzol on vacation)
 - rust-lang#135814 (ci: use ghcr buildkit image)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper
1f45302 
Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 ````@clarfonthey````
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
@bors
Auto merge of rust-lang#135835 - matthiaskrgr:rollup-pzaa7cn, r=matth…
f77ead0 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4)
 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135750 (Add an example of using `carrying_mul_add` to write wider multiplication)
 - rust-lang#135793 (Ignore `mermaid.min.js`)
 - rust-lang#135810 (Add Kobzol on vacation)
 - rust-lang#135816 (Use `structurally_normalize` instead of manual `normalizes-to` goals in alias relate errors)
 - rust-lang#135821 (fix OsString::from_encoded_bytes_unchecked description)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper
402e4e5 
Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 `````@clarfonthey`````
This was referenced Jan 21, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge of rust-lang#135848 - matthiaskrgr:rollup-sftciqm, r=matth…
c234b83 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4)
 - rust-lang#135706 (Move `supertrait_def_ids` into the elaborate module like all other fns)
 - rust-lang#135750 (Add an example of using `carrying_mul_add` to write wider multiplication)
 - rust-lang#135793 (Ignore `mermaid.min.js`)
 - rust-lang#135810 (Add Kobzol on vacation)
 - rust-lang#135821 (fix OsString::from_encoded_bytes_unchecked description)
 - rust-lang#135824 (tests: delete `cat-and-grep-sanity-check`)
 - rust-lang#135833 (Add fixme and test for issue rust-lang#135289)

Failed merges:

 - rust-lang#135816 (Use `structurally_normalize` instead of manual `normalizes-to` goals in alias relate errors)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 317769f into rust-lang:master Jan 22, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 22, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@rust-timer
Unrolled build for rust-lang#135750
6c41997 
Rollup merge of rust-lang#135750 - scottmcm:cma-example, r=cuviper

Add an example of using `carrying_mul_add` to write wider multiplication

Just the basic quadratic version that you wouldn't actually use for really-big integers, but it's nice and short so is useful as for a demonstration of why you might find `carrying_mul_add` useful :)

cc rust-lang#85532 ``````@clarfonthey``````
@scottmcm scottmcm deleted the cma-example branch January 22, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scottmcm @rustbot @cuviper @bors