Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize vec_pop_if #135488

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Stabilize vec_pop_if #135488

merged 1 commit into from
Feb 10, 2025

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jan 14, 2025 •
edited by tgross35
Loading

Tracking issue: #122741

FCP completed in #122741 (comment)

Closes #122741

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 14, 2025
@jhpratt jhpratt added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Jan 15, 2025
@jhpratt
Copy link
Member

jhpratt commented Jan 15, 2025

r=me with completed FCP

@jhpratt jhpratt added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2025
@Amanieu Amanieu added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 21, 2025
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 22, 2025
Closed
5 tasks
@rustbot rustbot removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Jan 22, 2025
@tgross35
Copy link
Contributor

Since FCP hasn't started, want to move the docs and signature update to a separate PR? We can merge that now and just leave the stabilization for whenever FCP completes.

@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 23, 2025
Merged
@GrigorenkoPV
Copy link
Contributor Author

Since FCP hasn't started, want to move the docs and signature update to a separate PR? We can merge that now and just leave the stabilization for whenever FCP completes.

Sure! Filed #135956

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2025
@matthiaskrgr
Rollup merge of rust-lang#135956 - GrigorenkoPV:vec_pop_off, r=dtolnay
85b1d54 
Make `Vec::pop_if` a bit more presentable

rust-lang#135488 minus stabilization.

As suggested in rust-lang#135488 (comment).

r? tgross35
@bors
Copy link
Contributor

bors commented Jan 24, 2025

☔ The latest upstream changes (presumably #135978) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2025
@matthiaskrgr
Rollup merge of rust-lang#135956 - GrigorenkoPV:vec_pop_off, r=dtolnay
b344e14 
Make `Vec::pop_if` a bit more presentable

rust-lang#135488 minus stabilization.

As suggested in rust-lang#135488 (comment).

r? tgross35
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@rust-timer
Unrolled build for rust-lang#135956
ca82e91 
Rollup merge of rust-lang#135956 - GrigorenkoPV:vec_pop_off, r=dtolnay

Make `Vec::pop_if` a bit more presentable

rust-lang#135488 minus stabilization.

As suggested in rust-lang#135488 (comment).

r? tgross35
@GrigorenkoPV
Copy link
Contributor Author

@rustbot label -S-waiting-on-author

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 27, 2025
@matthiaskrgr
Rollup merge of #135956 - GrigorenkoPV:vec_pop_off, r=dtolnay
f48c717 
Make `Vec::pop_if` a bit more presentable

#135488 minus stabilization.

As suggested in rust-lang/rust#135488 (comment).

r? tgross35
@GrigorenkoPV
Copy link
Contributor Author

@rustbot label -S-waiting-on-fcp

r=me with completed FCP

r? @jhpratt

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2025

Could not assign reviewer from: jhpratt.
User(s) jhpratt are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@rustbot rustbot removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Feb 9, 2025
@dtolnay
Copy link
Member

dtolnay commented Feb 9, 2025

@bors r=jhpratt

@bors
Copy link
Contributor

bors commented Feb 9, 2025

📌 Commit 2ecb40e has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2025
Urgau added a commit to Urgau/rust that referenced this pull request Feb 9, 2025
@Urgau
Rollup merge of rust-lang#135488 - GrigorenkoPV:vec_pop_if, r=jhpratt
13dc27a 
Stabilize `vec_pop_if`

Tracking issue: rust-lang#122741

FCP completed in rust-lang#122741 (comment)
@Urgau Urgau mentioned this pull request Feb 9, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2025
@bors
Auto merge of rust-lang#136774 - Urgau:rollup-cm061qo, r=Urgau
ea6fdd2 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134999 (Add cygwin target.)
 - rust-lang#135488 (Stabilize `vec_pop_if`)
 - rust-lang#136068 (crashes: more tests)
 - rust-lang#136694 (Update minifier version to `0.3.4`)
 - rust-lang#136760 (Fix unwrap error in overflowing int literal)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@bors
Auto merge of rust-lang#136785 - matthiaskrgr:rollup-sdhlna8, r=matth…
d9a4a47 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135488 (Stabilize `vec_pop_if`)
 - rust-lang#136068 (crashes: more tests)
 - rust-lang#136694 (Update minifier version to `0.3.4`)
 - rust-lang#136722 (Visit all debug info in MIR Visitor)
 - rust-lang#136746 (Emit an error if `-Zdwarf-version=1` is requested)
 - rust-lang#136760 (Fix unwrap error in overflowing int literal)
 - rust-lang#136782 (Fix mistake in x86_64-unknown-freebsd platform description)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b83a30c into rust-lang:master Feb 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@rust-timer
Unrolled build for rust-lang#135488
a11e030 
Rollup merge of rust-lang#135488 - GrigorenkoPV:vec_pop_if, r=jhpratt

Stabilize `vec_pop_if`

Tracking issue: rust-lang#122741

FCP completed in rust-lang#122741 (comment)
@GrigorenkoPV GrigorenkoPV deleted the vec_pop_if branch February 10, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Vec::pop_if
7 participants
@GrigorenkoPV @rustbot @jhpratt @tgross35 @bors @dtolnay @Amanieu