Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement OsString::truncate #133264

Merged
merged 1 commit into from
Nov 23, 2024
Merged

implement OsString::truncate #133264

merged 1 commit into from
Nov 23, 2024

Conversation

lolbinarycat
Copy link
Contributor

part of #133262

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2024
@lolbinarycat
Copy link
Contributor Author

because this is replacing an existing function that is presumably used for path manipulations, it should be benchmarked.

if there are regressions, we can add an internal "unchecked" version

@joboet
Copy link
Member

joboet commented Nov 22, 2024

I don't think benchmarking is necessary here, the compiler doesn't really use path manipulations that much. Anyway, this looks good to me.

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Nov 22, 2024

📌 Commit 7e79f91 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2024
@compiler-errors compiler-errors mentioned this pull request Nov 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133360 - compiler-errors:rollup-a2o38tq, r=co…
c49a687 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#132090 (Stop being so bail-y in candidate assembly)
 - rust-lang#132658 (Detect const in pattern with typo)
 - rust-lang#132911 (Pretty print async fn sugar in opaques and trait bounds)
 - rust-lang#133102 (aarch64 softfloat target: always pass floats in int registers)
 - rust-lang#133159 (Don't allow `-Zunstable-options` to take a value )
 - rust-lang#133208 (generate-copyright: Now generates a library file too.)
 - rust-lang#133215 (Fix missing submodule in `./x vendor`)
 - rust-lang#133264 (implement OsString::truncate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b3e593 into rust-lang:master Nov 23, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@rust-timer
Unrolled build for rust-lang#133264
8856498 
Rollup merge of rust-lang#133264 - lolbinarycat:os-string-truncate, r=joboet

implement OsString::truncate

part of rust-lang#133262
@rustbot rustbot added this to the 1.85.0 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lolbinarycat @rustbot @joboet @bors