Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.11-pre #13296

Merged
merged 1 commit into from
Apr 4, 2014
Merged

Bump version to 0.11-pre #13296

merged 1 commit into from
Apr 4, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 3, 2014

This also changes some of the download links in the documentation
to 'nightly'.

This also changes some of the download links in the documentation
to 'nightly'.
bors added a commit that referenced this pull request Apr 4, 2014
This also changes some of the download links in the documentation
to 'nightly'.
@bors bors closed this Apr 4, 2014
@bors bors merged commit 0875ffc into rust-lang:master Apr 4, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Oct 11, 2022
…name, r=Veykril

Fix PackageInformation having the crate name instead of package name

The `PackageInformation` type from the LSIF PR used the _crate_ name instead of the _package_ name. This caused issues when looking up crates by this name on the Sourcegraph backend, where we sync crate contents, for crates such as actix-web and many of its components (actix-files, actix-http etc etc), see screenshot 1 for the observed symptom.

This PR hasnt been tested on other entry points besides cargo (such as project json).

See screenshot 2 for the change in behaviour via SCIP snapshot comparison.

<details>
<summary>Screenshot 1</summary>

![crates.io giving 404](https://user-images.githubusercontent.com/18282288/192286637-8bf7c333-4441-4e60-8cce-de7eaa11ee9f.png)

</details>

<details>
<summary>Screenshot 2</summary>

![before and after from SCIP snapshot output](https://user-images.githubusercontent.com/18282288/192287733-d7e73ff0-abbc-4ae5-82d0-bf9dc45d755c.png)

</details>

Follow-up PR to my question over at the [rust-lang Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/canonical.20crate.20name.20confusion.20for.20monikers), excuse any incorrect usages of the term package vs crate.
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Aug 24, 2024
Replace more uses of `snippet_opt`.

Almost all calls are removed after this.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants