std: make vec!() macro handle a trailing comma #13278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // leading _ to allow empty construction without a warning. | ||
| let mut _temp = ::std::vec::Vec::new(); | ||
| $(_temp.push($e);)* | ||
| _temp |
There was a problem hiding this comment.
In order to prevent duplication, could you change this to:
($($e:expr),+,) => (vec!($($e),+))
| @@ -273,7 +273,8 @@ macro_rules! vec( | |||
| let mut _temp = ::std::vec::Vec::new(); | |||
| $(_temp.push($e);)* | |||
| _temp | |||
| }) | |||
| }); | |||
| ($($e:expr),+,) => (vec!($($e),+)) | |||
There was a problem hiding this comment.
This can also be written as `$($e:expr,)+
There was a problem hiding this comment.
Well, I thought it is less confusing in this way. Is there any non-cosmetic downside (e.g. macro invocation parser does not like it)?
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 24, 2024
Misc cleanup changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12910.