Remove or fix some more FIXME(async_closure)
#132488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Nov 2, 2024
| @@ -432,7 +432,6 @@ where | |||
| upvar.visit_with(self); | |||
| } | |||
|
|
|||
| // FIXME(async_closures): Is this the right signature to visit here? | |||
There was a problem hiding this comment.
it gets the job done.
| @@ -5,9 +5,6 @@ | |||
| //@[v0] compile-flags: -Csymbol-mangling-version=v0 | |||
| //@[legacy] compile-flags: -Csymbol-mangling-version=legacy -Zunstable-options | |||
|
|
|||
| // FIXME(async_closures): When `fn_sig_for_fn_abi` is fixed, remove this. | |||
| @@ -38,7 +38,10 @@ fn through_field_and_ref<'a>(x: &S<'a>) { | |||
|
|
|||
| let c = async move || { println!("{}", *x.0); }; | |||
| outlives::<'a>(c()); | |||
| // outlives::<'a>(call_once(c)); // FIXME(async_closures): Figure out why this fails | |||
|
|
|||
| // outlives::<'a>(call_once(c)); | |||
There was a problem hiding this comment.
Explanation for why this fails, since I understand it now, and it's totally expected.
| @@ -126,7 +126,7 @@ async fn async_main() { | |||
| { | |||
| let mut s = S { a: 1, b: Drop("drop first"), c: Drop("untouched") }; | |||
| let c = guidance!(async move || { | |||
| // s.a = 2; // FIXME(async_closures): Figure out why this fails | |||
| s.a = 2; | |||
| @@ -38,10 +38,12 @@ fn through_field_and_ref<'a>(x: &S<'a>) { | |||
| let c = async || { println!("{}", *x.0); }; //~ ERROR `x` does not live long enough | |||
| outlives::<'a>(c()); | |||
| outlives::<'a>(call_once(c)); //~ ERROR explicit lifetime required in the type of `x` | |||
| } | |||
There was a problem hiding this comment.
Split into two functions since one error actually just suppresses the other (due to NLL error deduplication, I believe).
| let c = async move || { println!("{}", *x.0); }; | ||
| outlives::<'a>(c()); //~ ERROR `c` does not live long enough | ||
| // outlives::<'a>(call_once(c)); // FIXME(async_closures): Figure out why this fails | ||
| outlives::<'a>(call_once(c)); //~ ERROR explicit lifetime required in the type of `x` |
There was a problem hiding this comment.
This is expected to fail for the same reason as I elaborated above in tests/ui/async-await/async-closures/no-borrow-from-env.rs.
|
r? jieyouxu |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 2, 2024
…=jieyouxu Remove or fix some more `FIXME(async_closure)` Self-explanatory
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Nov 2, 2024
…=jieyouxu Remove or fix some more `FIXME(async_closure)` Self-explanatory
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132333 (rust_analyzer_helix.toml: add library/ manifest) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132411 (CI: switch dist-x86_64-musl to free runner) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2024
Rollup merge of rust-lang#132488 - compiler-errors:more-fixmes-bye, r=jieyouxu Remove or fix some more `FIXME(async_closure)` Self-explanatory
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory