Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protected visibility for librustc_driver.so when possible #132219

Closed
wants to merge 1 commit into from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 27, 2024

This should make rustc faster to start by reducing the load on the dynamic linker.

This should make rustc faster to start by reducing the load on the
dynamic linker.
@bjorn3
Copy link
Member Author

bjorn3 commented Oct 27, 2024

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-timer

This comment has been minimized.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 27, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Oct 27, 2024

Missed #131634 which already does this and more.

@bjorn3 bjorn3 closed this Oct 27, 2024
@bors
Copy link
Contributor

bors commented Oct 27, 2024

⌛ Trying commit e6cf7da with merge f43c51d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…=<try>

Use protected visibility for librustc_driver.so when possible

This should make rustc faster to start by reducing the load on the dynamic linker.
@bjorn3 bjorn3 deleted the rustc_protected_visibility branch October 27, 2024 09:48
@saethlin
Copy link
Member

This has been trying for 14 hours? Wat?
@bors try-

@jieyouxu
Copy link
Member

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@jieyouxu
Copy link
Member

@bors r-

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
…=<try>

Use protected visibility for librustc_driver.so when possible

This should make rustc faster to start by reducing the load on the dynamic linker.
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Trying commit e6cf7da with merge 5192687...

@jieyouxu
Copy link
Member

@bors r- retry

@jieyouxu
Copy link
Member

@bors r-

@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Trying commit e6cf7da with merge b3bffc2...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
…=<try>

Use protected visibility for librustc_driver.so when possible

This should make rustc faster to start by reducing the load on the dynamic linker.
@jieyouxu
Copy link
Member

?

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Try build successful - checks-actions
Build commit: b3bffc2 (b3bffc25ec0910da23a474db5893fa8f2b69cf0c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b3bffc2): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.6% [-31.3%, -0.1%] 190
Improvements ✅
(secondary)
-4.1% [-27.4%, -0.2%] 226
All ❌✅ (primary) -1.6% [-31.3%, -0.1%] 190

Max RSS (memory usage)

Results (primary -2.0%, secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-3.9%, -0.6%] 113
Improvements ✅
(secondary)
-2.8% [-5.9%, -0.6%] 137
All ❌✅ (primary) -2.0% [-3.9%, -0.6%] 113

Cycles

Results (primary -6.2%, secondary -6.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-6.2% [-23.3%, -1.1%] 20
Improvements ✅
(secondary)
-6.6% [-20.5%, -1.6%] 87
All ❌✅ (primary) -6.2% [-23.3%, -1.1%] 20

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.63s -> 780.424s (-0.41%)
Artifact size: 333.67 MiB -> 335.15 MiB (0.44%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants