-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #127731 "Emit error when calling/declaring functions with unavailable …" #132152
Conversation
…vectors." This reverts commit 5af56ca.
wow what a regression 😨 @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ae4c6b6): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -4.1%, secondary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -9.6%, secondary -8.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 787.606s -> 785.03s (-0.33%) |
This reverts #127731 due to the unexpected perf regressions and to give time to mitigate the regressions before re-landing it.
r? @RalfJung cc @veluca93