Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: rfl: use rust-next temporary commit #132058

Merged
merged 1 commit into from
Oct 23, 2024
Merged

CI: rfl: use rust-next temporary commit #132058

merged 1 commit into from
Oct 23, 2024

Conversation

adetaylor
Copy link
Contributor

@adetaylor adetaylor commented Oct 23, 2024 •
edited by lqd
Loading

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
#130225
#44874

r? @ojeda

try-job: x86_64-rust-for-linux

@adetaylor
CI: rfl: use rust-next temporary commit
2eb7e0d 
Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next
contains some changes required to be compatible with upcoming arbitraty
self types work. Roll RFL CI forward to the latest rust-next to include
that work.

Related:
rust-lang#130225
rust-lang#44874
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2024

Failed to set assignee to ojeda: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 23, 2024
@ojeda
Copy link
Contributor

ojeda commented Oct 23, 2024

Looks good to me, thanks!

(We could do this also in the other PR that needs it, but if it can be done independently first, even better.)

Let's give it a try run.

r? @lqd
r? @Kobzol

try-job: x86_64-rust-for-linux
@bors try

@rustbot label A-rust-for-linux

@rustbot rustbot added the A-rust-for-linux Relevant for the Rust-for-Linux project label Oct 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
@bors
Auto merge of rust-lang#132058 - adetaylor:use-rust-next-in-ci, r=<try>
e3d4205 
CI: rfl: use rust-next temporary commit

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
rust-lang#130225
rust-lang#44874

r? `@ojeda`
@bors
Copy link
Contributor

bors commented Oct 23, 2024

⌛ Trying commit 2eb7e0d with merge e3d4205...

@ojeda ojeda mentioned this pull request Oct 23, 2024
Open
7 tasks
@lqd
Copy link
Member

lqd commented Oct 23, 2024 •
edited
Loading

@ojeda you need try-job: x86_64-rust-for-linux in the PR description for this to work. Otherwise, it will use the default x64 linux dist build.

I added it, @bors try

@bors
Copy link
Contributor

bors commented Oct 23, 2024

⌛ Trying commit 2eb7e0d with merge f2f1c92...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
@bors
Auto merge of rust-lang#132058 - adetaylor:use-rust-next-in-ci, r=<try>
f2f1c92 
CI: rfl: use rust-next temporary commit

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
rust-lang#130225
rust-lang#44874

r? `@ojeda`

try-job: x86_64-rust-for-linux
@lqd
Copy link
Member

lqd commented Oct 23, 2024

r=me when the 2nd try build (this job, not this one) passes

@bors delegate=ojeda

@bors
Copy link
Contributor

bors commented Oct 23, 2024

✌️ @ojeda, you can now approve this pull request!

If @lqd told you to "r=me" after making some further change, please make that change, then do @bors r=@lqd

@ojeda
Copy link
Contributor

ojeda commented Oct 23, 2024

@ojeda you need try-job: x86_64-rust-for-linux in the PR description for this to work. Otherwise, it will use the default x64 linux dist build.

I added it, @bors try

Thanks! I was hoping it would pick it up in the entire thread like the other bots.

I don't have permission to edit PR descriptions, I think.

@bors
Copy link
Contributor

bors commented Oct 23, 2024

☀️ Try build successful - checks-actions
Build commit: f2f1c92 (f2f1c92b06cb588926fbfe26d8bce97ab2acf897)

@adetaylor
Copy link
Contributor Author

adetaylor commented Oct 23, 2024 •
edited
Loading

@lqd your try job passed

I wonder if I have permission to do this: (I suspect not)
@bors r=@lqd

@bors
Copy link
Contributor

bors commented Oct 23, 2024

@adetaylor: 🔑 Insufficient privileges: Not in reviewers

@ojeda
Copy link
Contributor

ojeda commented Oct 23, 2024

@bors r=@lqd

@bors
Copy link
Contributor

bors commented Oct 23, 2024

📌 Commit 2eb7e0d has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024
@lqd
Copy link
Member

lqd commented Oct 23, 2024

I was hoping it would pick it up in the entire thread like the other bots.

Not yet unfortunately. Any improvements there will need the bors rewrite (for example try=some_job), the current codebase is incredibly hard to change reliably without regressions, and this was the best we could do until then.

@ojeda
Copy link
Contributor

ojeda commented Oct 23, 2024

I see, thanks! I think you have a quite nice overall system regardless :)

fmease added a commit to fmease/rust that referenced this pull request Oct 23, 2024
@fmease
Rollup merge of rust-lang#132058 - adetaylor:use-rust-next-in-ci, r=lqd
8053a1b 
CI: rfl: use rust-next temporary commit

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
rust-lang#130225
rust-lang#44874

r? `@ojeda`

try-job: x86_64-rust-for-linux
This was referenced Oct 23, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
@bors
Auto merge of rust-lang#132070 - fmease:rollup-4i4k587, r=fmease
4f2f477 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#131043 (Refactor change detection for rustdoc and download-rustc)
 - rust-lang#131181 (Compiletest: Custom differ)
 - rust-lang#131487 (Add wasm32v1-none target (compiler-team/rust-lang#791))
 - rust-lang#132054 (do not remove `.cargo` directory)
 - rust-lang#132058 (CI: rfl: use rust-next temporary commit)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
@rust-timer
Unrolled build for rust-lang#132058
ad5c9fd 
Rollup merge of rust-lang#132058 - adetaylor:use-rust-next-in-ci, r=lqd

CI: rfl: use rust-next temporary commit

Commit c95bbb59a9b22f9b838b15d28319185c1c884329 within rust-next contains some changes required to be compatible with upcoming arbitraty self types work. Roll RFL CI forward to the latest rust-next to include that work.

Related:
rust-lang#130225
rust-lang#44874

r? ``@ojeda``

try-job: x86_64-rust-for-linux
@bors bors merged commit 5f0626c into rust-lang:master Oct 23, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 23, 2024
@wesleywiser wesleywiser mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

@Kobzol Kobzol

Labels
A-rust-for-linux Relevant for the Rust-for-Linux project A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@adetaylor @rustbot @ojeda @bors @lqd @Kobzol