fix suggestion for diagnostic error E0027 #132025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
compiler/rustc_hir_typeck/src/pat.rs
Outdated
| @@ -2053,7 +2053,11 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| .iter() | |||
| .map(|(_, name)| { | |||
| let field_name = name.to_string(); | |||
| if is_number(&field_name) { format!("{field_name}: _") } else { field_name } | |||
| if is_number(&field_name) { | |||
| format!("{}: _", field_name) | |||
There was a problem hiding this comment.
Why did you change this? {field_name}: _ is fine, right?
There was a problem hiding this comment.
I agree with you. There was no need for the change. I will revert it.
compiler-errors
requested changes
Oct 24, 2024
compiler/rustc_hir_typeck/src/pat.rs
Outdated
| @@ -2065,11 +2069,28 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| err.span_suggestion( | |||
| sp, | |||
| format!( | |||
| "if you don't care about {these} missing field{s}, you can explicitly ignore {them}", | |||
| these = pluralize!("this", len), | |||
| "if the value{s} {are} not relevant, discard {them} explicitly", | |||
There was a problem hiding this comment.
I think the message did not need to be changed. Tweaking the suggestion was sufficient.
There was a problem hiding this comment.
Ok, reverted the message change in 10b60eb.
rust/compiler/rustc_hir_typeck/src/pat.rs
Line 2068 in 10b60eb
rustbot
added
S-waiting-on-author
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Nov 4, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 5, 2024
fix suggestion for diagnostic error E0027 Closes rust-lang#132008
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#131153 (Improve duplicate derive Copy/Clone diagnostics) - rust-lang#131341 (Support clobber_abi and vector registers (clobber-only) in PowerPC inline assembly) - rust-lang#132025 (fix suggestion for diagnostic error E0027) - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132303 (More tests for non-exhaustive C-like enums in FFI) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion)) - rust-lang#132606 (Improve example of `impl Pattern for &[char]`) - rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2024
…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#131153 (Improve duplicate derive Copy/Clone diagnostics) - rust-lang#132025 (fix suggestion for diagnostic error E0027) - rust-lang#132303 (More tests for non-exhaustive C-like enums in FFI) - rust-lang#132492 (remove support for extern-block const intrinsics) - rust-lang#132587 (Revert "Avoid nested replacement ranges" from rust-lang#129346.) - rust-lang#132596 ([rustdoc] Fix `--show-coverage` when JSON output format is used) - rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion)) - rust-lang#132601 (Update books) - rust-lang#132606 (Improve example of `impl Pattern for &[char]`) - rust-lang#132608 (document `type_implements_trait`) - rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2024
Rollup merge of rust-lang#132025 - duncpro:E0027, r=compiler-errors fix suggestion for diagnostic error E0027 Closes rust-lang#132008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132008