Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Use LLVM's Comdat support #131876

Merged
merged 3 commits into from
Oct 20, 2024
Merged

compiler: Use LLVM's Comdat support #131876

merged 3 commits into from
Oct 20, 2024

Commits on Oct 19, 2024

  1. cg_llvm: Switch llvm::add_global to &CStr

    @workingjubilee
    workingjubilee committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    888efe7 View commit details
    Browse the repository at this point in the history

  2. cg_llvm: Reuse LLVM-C Comdat support 

    Migrate `llvm::set_comdat` and `llvm::SetUniqueComdat` to LLVM-C FFI.

Note, now we can call `llvm::set_comdat` only when the target actually
supports adding comdat. As this has no convenient LLVM-C API, we
implement this as `TargetOptions::supports_comdat`.

Co-authored-by: Stuart Cook <[email protected]>
    @workingjubilee @Zalathar
    workingjubilee and Zalathar committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    45d61b0 View commit details
    Browse the repository at this point in the history

  3. llvm: Delete LLVMRustSetComdat

    @workingjubilee
    workingjubilee committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4927600 View commit details
    Browse the repository at this point in the history