switch unicode-data bitsets back to 'static' #131641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
changed the title
RalfJung
force-pushed
the
unicode-bitset-static
branch
from
5f1e903
to
90e4f10
Compare
|
Ah good point, I had missed that. Yes we can make them arrays again without an extra indirection. @bors r=dtolnay |
bors
added
S-waiting-on-bors
3 tasks
dtolnay
approved these changes
Oct 13, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131086 (Update unicode-width to 0.2.0) - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`) - rust-lang#131614 (Error on trying to use revisions in `run-make` tests) - rust-lang#131638 (compiletest: Move debugger setup code out of `lib.rs`) - rust-lang#131641 (switch unicode-data bitsets back to 'static') - rust-lang#131642 (Special case error message for a `build-fail` test that failed check build) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
Rollup merge of rust-lang#131641 - RalfJung:unicode-bitset-static, r=dtolnay switch unicode-data bitsets back to 'static' Back in rust-lang#101401, these were changed to `const` to make some functions `const fn`. However, `@dtolnay` was [not happy](rust-lang#101400 (comment)) about this. Meanwhile, `const fn` can access immutable statics like these, so we can change this back. Part of rust-lang#101400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #101401, these were changed to
constto make some functionsconst fn. However, @dtolnay was not happy about this. Meanwhile,const fncan access immutable statics like these, so we can change this back.Part of #101400.