Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: detect stack overflows in TLS destructors on UNIX #131282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std: detect stack overflows in TLS destructors on UNIX #131282

wants to merge 1 commit into from

Commits on Oct 5, 2024

  1. std: detect stack overflows in TLS destructors on UNIX 

    Fixes rust-lang#111272.

With rust-lang#127912 merged, we now have all the infrastructure in place to support stack overflow detection in TLS destructors. This was not possible before because the signal stack was freed in the thread main function, thus a SIGSEGV afterwards would immediately crash. And on platforms without native TLS, the guard page address was stored in an allocation freed in a TLS destructor, so would not be available. rust-lang#127912 introduced the `local_pointer` macro which allows storing a pointer-sized TLS variable without allocation and the `thread_cleanup` runtime function which is called after all other code managed by the Rust runtime. This PR simply moves the signal stack cleanup to the end of `thread_cleanup` and uses `local_pointer` to store every necessary variable. And so, everything run under the Rust runtime is now properly protected against stack overflows.
    @joboet
    joboet committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    f46b255 View commit details
    Browse the repository at this point in the history