Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etc: Add sample rust-analyzer configs for eglot & helix #130932

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

mrkajetanp
Copy link
Contributor

LSP configuration in editors like Emacs (eglot) and helix does not
use the same JSON format as vscode and vim do. It is not obvious
how to set up LSP for rustc in those editors and the dev guide currently
does not cover them. Adding sample configuration files for those editors
alongside the currently existing JSON one would be helpful.

I figured having those included in the repo like the JSON one might save
someone some time and frustration otherwise spent on trying to get the
more niche editors' LSP to work properly. I'll add a section in the dev
guide too.

LSP configuration in editors like Emacs (eglot) and helix does not
use the same JSON format as vscode and vim do. It is not obvious
how to set up LSP for rustc in those editors and the dev guide currently
does not cover them. Adding sample configuration files for those editors
alongside the currently existing JSON one would be helpful.
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 27, 2024
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit a1846ec has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 243c6d6 into rust-lang:master Sep 28, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
Rollup merge of rust-lang#130932 - mrkajetanp:editors, r=jieyouxu

etc: Add sample rust-analyzer configs for eglot & helix

LSP configuration in editors like Emacs (eglot) and helix does not
use the same JSON format as vscode and vim do. It is not obvious
how to set up LSP for rustc in those editors and the dev guide currently
does not cover them. Adding sample configuration files for those editors
alongside the currently existing JSON one would be helpful.

I figured having those included in the repo like the JSON one might save
someone some time and frustration otherwise spent on trying to get the
more niche editors' LSP to work properly. I'll add a section in the dev
guide too.
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@veera-sivarajan
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants