Rollup of 10 pull requests #130253

workingjubilee · 2024-09-11T22:53:25Z

Successful merges:

Don't warn empty branches unreachable for now #129103 (Don't warn empty branches unreachable for now)
update stdarch #129696 (update stdarch)
enable const-float-classify test, and test_next_up/down on 32bit x86 #129835 (enable const-float-classify test, and test_next_up/down on 32bit x86)
Fix linking error when compiling for 32-bit watchOS #130077 (Fix linking error when compiling for 32-bit watchOS)
Remove needless returns detected by clippy in the compiler #130114 (Remove needless returns detected by clippy in the compiler)
maint: update docs for change_time ext and doc links #130168 (maint: update docs for change_time ext and doc links)
notify Miri when intrinsics are changed #130228 (notify Miri when intrinsics are changed)
miri: fix overflow detection for unsigned pointer offset #130239 (miri: fix overflow detection for unsigned pointer offset)
Use the same span for attributes and Try expansion of ? #130244 (Use the same span for attributes and Try expansion of ?)
Limit libc::link usage to nto70 target only, not NTO OS #130248 (Limit libc::link usage to nto70 target only, not NTO OS)

r? @ghost
@rustbot modify labels: rollup

In rust-lang#124748, I mistakenly conflated "not SjLj" to mean "ARM EHABI", which isn't true, watchOS armv7k (specifically only that architecture) uses a third unwinding method called "DWARF CFI".

- remove an outdated FIXME - add reference to floating-point semantics issue Co-authored-by: Jubilee <[email protected]>

This is needed for Clippy to know that the `#[allow(unused)]` attributes added by the expansion of `?` are part of the desugaring, and that they do not come from the user code. rust-lang/rust-clippy#13380 exhibits a manifestation of this problem.

It seems QNX 7.0 does not support `linkat` at all (most tests were failing). Limiting to QNX 7.0 only, while using `linkat` for the future versions seems like the right path forward (tested on 7.0). Fixes 129895

…ble, r=compiler-errors Don't warn empty branches unreachable for now The [stabilization](rust-lang#122792) of `min_exhaustive_patterns` updated the `unreachable_pattern` lint to trigger on empty arms too. This has caused some amount of churn, and imposes an unjoyful `#[allow(unreachable_patterns)]` onto library authors who want to stay backwards-compatible. While I think the lint should eventually cover these cases, for transition's sake I'd prefer to revert linting to what it was prior to stabilization, at least for now. Fixes rust-lang#129031. r? ``@compiler-errors``

update stdarch The goal is mostly to pull in rust-lang/stdarch#1633. r? ```@Amanieu```

…ilee enable const-float-classify test, and test_next_up/down on 32bit x86 The test_next_up/down tests have been disabled on all 32bit x86 targets, which goes too far -- they should definitely work on our (tier 1) i686 target, it is only without SSE that we might run into trouble due to rust-lang#114479. However, I cannot reproduce that trouble any more -- maybe that got fixed by rust-lang#123351? The const-float-classify test relied on const traits "because we can", and got disabled when const traits got removed. That's an unfortunate reduction in test coverage of our float functionality, so let's restore the test in a way that does not rely on const traits. The const-float tests are actually testing runtime behavior as well, and I don't think that runtime behavior is covered anywhere else. Probably they shouldn't be called "const-float", but we don't have a `tests/ui/float` folder... should I create one and move them there? Are there any other ui tests that should be moved there? I also removed some FIXME referring to not use x87 for Rust-to-Rust-calls -- that has happened in rust-lang#123351 so this got fixed indeed. Does that mean we can simplify all that float code again? I am not sure how to test it. Is running the test suite with an i586 target enough? Cc ```@tgross35``` ```@workingjubilee```

…ingjubilee Fix linking error when compiling for 32-bit watchOS In rust-lang#124494 (or rust-lang#124748), I mistakenly conflated "not SjLj" to mean "ARM EHABI", which isn't true, 32-bit watchOS uses a third unwinding method called "DWARF CFI". So this PR is effectively a revert of rust-lang#124494, with a few more comments explaining what's going on. Fixes rust-lang#130071. r? Mark-Simulacrum (since you reviewed the original)

…iler-errors Remove needless returns detected by clippy in the compiler

…links, r=ChrisDenton maint: update docs for change_time ext and doc links maint: update docs for change_time ext and doc links Related: rust-lang#121478 r? tgross35

…hlin notify Miri when intrinsics are changed `@rust-lang/miri` should we notify the entire team, or should I just add myself?

… r=compiler-errors miri: fix overflow detection for unsigned pointer offset This is the Miri part of rust-lang#130229. This is already UB in codegen so we better make Miri detect it; updating the docs may take time if we have to follow some approval process, but let's make Miri match reality ASAP. r? ``@scottmcm``

…-fix, r=jieyouxu Use the same span for attributes and Try expansion of ? This is needed for Clippy to know that the `#[allow(unused)]` attributes added by the expansion of `?` are part of the desugaring, and that they do not come from the user code. rust-lang/rust-clippy#13380 exhibits a manifestation of this problem and will be fixed by this change.

Limit `libc::link` usage to `nto70` target only, not NTO OS It seems QNX 7.0 does not support `linkat` at all (most tests were failing). Limiting to QNX 7.0 only, while using `linkat` for the future versions seems like the right path forward (tested on 7.0). Fixes rust-lang#129895 CC: `@japaric` `@flba-eb` `@saethlin`

workingjubilee · 2024-09-11T22:55:33Z

@bors r+ rollup=never p=10

bors · 2024-09-11T22:55:36Z

📌 Commit b4201d3 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-09-11T23:23:29Z

⌛ Testing commit b4201d3 with merge 3afb2bb...

bors · 2024-09-12T01:59:49Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 3afb2bb to master...

rust-timer · 2024-09-12T02:02:35Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129103	Don't warn empty branches unreachable for now	`34f6683882faa9e7404a1fc679e7a4c15af53c3f` (link)
#129696	update stdarch	`68941a6bfc9690ed48d5ab36dfe186e6655bbd90` (link)
#129835	enable const-float-classify test, and test_next_up/down on …	`74cdc551e652dc092a4bcd78ac788b5cd3abd71f` (link)
#130077	Fix linking error when compiling for 32-bit watchOS	`2e9d8309a2c4420a4bb9468251ee58b64447898b` (link)
#130114	Remove needless returns detected by clippy in the compiler	`20ab8662720e74fd083a183287c0e262012f5d0b` (link)
#130168	maint: update docs for change_time ext and doc links	`cb4bb31192724505a028bbfb1a267cd13361fe26` (link)
#130228	notify Miri when intrinsics are changed	`8dafbe7de585773558fd6c22fc8484aa67833ec9` (link)
#130239	miri: fix overflow detection for unsigned pointer offset	`dc046cf8c0ddfe1b0f2078d6dea9fa1bad406f11` (link)
#130244	Use the same span for attributes and Try expansion of ?	`31315112976ab9671c779fb61a2d4182f96c33a4` (link)
#130248	Limit `libc::link` usage to `nto70` target only, not NTO OS	`64ab2b86e57eb789f0df1ad1362f7846705fc61f` (link)

previous master: 8d6b88b168

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-09-12T03:14:26Z

Finished benchmarking commit (3afb2bb): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.5%, -0.2%]	13
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.5%, 0.2%]	14

Max RSS (memory usage)

Results (primary -1.0%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-1.3%	[-2.3%, -0.7%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-2.3%, 1.0%]	7

Cycles

Results (primary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-2.0%, -0.9%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-2.0%, -0.9%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.94s -> 756.901s (-0.01%)
Artifact size: 341.41 MiB -> 341.35 MiB (-0.02%)

madsmtm and others added 27 commits September 8, 2024 09:12

Fix linking error when compiling for 32-bit watchOS

f98ca32

In rust-lang#124748, I mistakenly conflated "not SjLj" to mean "ARM EHABI", which isn't true, watchOS armv7k (specifically only that architecture) uses a third unwinding method called "DWARF CFI".

Remove needless returns detected by clippy in the compiler

0b20ffc

maint: update docs for change_time ext and doc links

2f1e1be

chore: removing supporting links in favor of existing doc-comment style

a0a89e5

these tests seem to work fine on i586 these days

180eace

move float tests into their own dir

c40ee79

enable and extend float-classify test

3daa951

clean up internal comments about float semantics

e556c13

- remove an outdated FIXME - add reference to floating-point semantics issue Co-authored-by: Jubilee <[email protected]>

update stdarch

b44f1dd

miri: support vector index arguments in simd_shuffle

542a6c6

notify Miri when intrinsics are changed

db40dc3

Revert warning empty patterns as unreachable

5b7be14

docs: remove struct info

6c84238

miri: fix overflow detection for unsigned pointer offset

3842ea6

chore: remove struct details

5527076

Limit libc::link usage to nto70 target only, not NTO OS

368231c

It seems QNX 7.0 does not support `linkat` at all (most tests were failing). Limiting to QNX 7.0 only, while using `linkat` for the future versions seems like the right path forward (tested on 7.0). Fixes 129895

Rollup merge of rust-lang#129696 - RalfJung:stdarch, r=Amanieu

abf0ac5

update stdarch The goal is mostly to pull in rust-lang/stdarch#1633. r? ```@Amanieu```

Rollup merge of rust-lang#130114 - eduardosm:needless-returns, r=comp…

a31a8fe

…iler-errors Remove needless returns detected by clippy in the compiler

Rollup merge of rust-lang#130168 - juliusl:pr/fix-win-fs-change-time-…

eb9a4f7

…links, r=ChrisDenton maint: update docs for change_time ext and doc links maint: update docs for change_time ext and doc links Related: rust-lang#121478 r? tgross35

Rollup merge of rust-lang#130228 - RalfJung:intrinsics-notify, r=saet…

1e3d1ad

…hlin notify Miri when intrinsics are changed `@rust-lang/miri` should we notify the entire team, or should I just add myself?

rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself O-unix Operating system: Unix-like O-windows Operating system: Windows labels Sep 11, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2024

bors merged commit 3afb2bb into rust-lang:master Sep 12, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 12, 2024

workingjubilee deleted the rollup-npqpnaf branch September 12, 2024 02:23

This was referenced Sep 12, 2024

feat: add tier-1 platform support for change_time #128256

Draft

Add a machine-applicable suggestion to "unreachable pattern" #128991

Merged

Stabilize const_float_classify #130157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #130253

Rollup of 10 pull requests #130253

workingjubilee commented Sep 11, 2024

workingjubilee commented Sep 11, 2024

bors commented Sep 11, 2024

bors commented Sep 11, 2024

bors commented Sep 12, 2024

rust-timer commented Sep 12, 2024

rust-timer commented Sep 12, 2024

Rollup of 10 pull requests #130253

Rollup of 10 pull requests #130253

Conversation

workingjubilee commented Sep 11, 2024

workingjubilee commented Sep 11, 2024

bors commented Sep 11, 2024

bors commented Sep 11, 2024

bors commented Sep 12, 2024

rust-timer commented Sep 12, 2024

rust-timer commented Sep 12, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size