-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpreter typed copy validation: statically disable padding/provenance in CTFE machine #130182
interpreter typed copy validation: statically disable padding/provenance in CTFE machine #130182
Conversation
…nce in CTFE machine
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
@rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…venance-reset, r=<try> interpreter typed copy validation: statically disable padding/provenance in CTFE machine Let's see if this fixes the perf impact in rust-lang#129778. r? `@saethlin`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (f23fee1): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -2.4%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 756.628s -> 756.432s (-0.03%) |
Ah, so this is not even where the slowdown comes from then... 🤔 |
Let's see if this fixes the perf impact in #129778.
r? @saethlin