-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prereq3 for async drop - LangItem registration for async_drop_in_place()::{{closure0}} #129737
base: master
Are you sure you want to change the base?
Prereq3 for async drop - LangItem registration for async_drop_in_place()::{{closure0}} #129737
Conversation
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
7a0329a
to
3c5bee0
Compare
d8c1a84
to
50aea7e
Compare
☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @nikomatsakis is going to look into this |
50aea7e
to
c561fb9
Compare
☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts. |
c561fb9
to
3534899
Compare
☔ The latest upstream changes (presumably #136943) made this pull request unmergeable. Please resolve the merge conflicts. |
This is subpart 3 PR of #123948, just for review purposes.
We have
async_drop_in_place
lang item forasync fn async_drop_in_place<T>(...)
.But we also need to generate shim for its returning value - coroutine
async_drop_in_place<T>::{{closure0}}
.So, we need to bind some lang item to it. This patch registers
LangItem::AsyncDropInPlacePoll
for coroutine, when its constructor function isLangItem::AsyncDropInPlace
.Review only last commit, based on previous PR #129736