-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #129304
Rollup of 6 pull requests #129304
Commits on Aug 4, 2024
-
Special case DUMMY_SP to emit line 0/column 0 locations on DWARF plat…
…forms. Line 0 has a special meaning in DWARF. From the version 5 spec: The compiler may emit the value 0 in cases where an instruction cannot be attributed to any source line. DUMMY_SP spans cannot be attributed to any line. However, because rustc internally stores line numbers starting at zero, lookup_debug_loc() adjusts every line number by one. Special casing DUMMY_SP to actually emit line 0 ensures rustc communicates to the debugger that there's no meaningful source code for this instruction, rather than telling the debugger to jump to line 1 randomly.
Configuration menu - View commit details
-
Copy full SHA for 78caecf - Browse repository at this point
Copy the full SHA 78caecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e587855 - Browse repository at this point
Copy the full SHA e587855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dc4a19 - Browse repository at this point
Copy the full SHA 5dc4a19View commit details
Commits on Aug 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 803cbaf - Browse repository at this point
Copy the full SHA 803cbafView commit details
Commits on Aug 18, 2024
-
bootstrap: fix clean's
remove_dir_all
implementation... by using `std::fs::remove_dir_all`, which handles a bunch of edge cases including read-only files and symlinks which are extremely tricky on Windows.
Configuration menu - View commit details
-
Copy full SHA for 1687c55 - Browse repository at this point
Copy the full SHA 1687c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f39427 - Browse repository at this point
Copy the full SHA 9f39427View commit details -
move
Build::update_submodule
toConfig::update_submodule
During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config` instance, so we can access to it during the parsing process. Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7832b8 - Browse repository at this point
Copy the full SHA c7832b8View commit details -
bypass
dry_run
if the command isrun_always
Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d0f3b2 - Browse repository at this point
Copy the full SHA 3d0f3b2View commit details -
sync llvm submodule during config parse
Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ca2708 - Browse repository at this point
Copy the full SHA 1ca2708View commit details
Commits on Aug 19, 2024
-
fix broken bootstrap documentation
Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2d8fa4 - Browse repository at this point
Copy the full SHA d2d8fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc3993 - Browse repository at this point
Copy the full SHA 5fc3993View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c735a0 - Browse repository at this point
Copy the full SHA 3c735a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9725c - Browse repository at this point
Copy the full SHA 4e9725cView commit details -
rustdoc: animate the
:target
highlightThis approach is, roughly, based on how Discourse does it. It came up while discussing some other possible sidebar changes, as a design that made rapid scanning easier while avoiding the inherent trade-offs in summarizing.
Configuration menu - View commit details
-
Copy full SHA for 9d7574f - Browse repository at this point
Copy the full SHA 9d7574fView commit details -
Rollup merge of rust-lang#127623 - lolbinarycat:fix_remove_dir_all, r…
…=Amanieu fix: fs::remove_dir_all: treat internal ENOENT as success fixes rust-lang#127576 try-job: test-various
Configuration menu - View commit details
-
Copy full SHA for d38d4e5 - Browse repository at this point
Copy the full SHA d38d4e5View commit details -
Rollup merge of rust-lang#128627 - khuey:DUMMY_SP-line-no, r=nnethercote
Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms. Line 0 has a special meaning in DWARF. From the version 5 spec: The compiler may emit the value 0 in cases where an instruction cannot be attributed to any source line. DUMMY_SP spans cannot be attributed to any line. However, because rustc internally stores line numbers starting at zero, lookup_debug_loc() adjusts every line number by one. Special casing DUMMY_SP to actually emit line 0 ensures rustc communicates to the debugger that there's no meaningful source code for this instruction, rather than telling the debugger to jump to line 1 randomly.
Configuration menu - View commit details
-
Copy full SHA for fb6c9af - Browse repository at this point
Copy the full SHA fb6c9afView commit details -
Rollup merge of rust-lang#129187 - jieyouxu:squeaky-clean-windows-sym…
…links, r=Kobzol bootstrap: fix clean's remove_dir_all implementation It turns out bootstrap's `clean.rs`'s hand-rolled `rm_rf` (which probably comes before `std::fs::remove_dir_all` was stable) is very broken on native Windows around both read-only files/directories and especially symbolic links. So instead of rolling our own, just use `std::fs::remove_dir_all`. This is a blocker for compiletest's own `rm_rf` implementation rust-lang#129155 which happens to be also buggy, which in turn is a blocker for the rmake.rs test port rust-lang#128562 that heavily exercises symlinks (I was reviewing rust-lang#128562 and testing it on native Windows which is how I found out). I also left a FIXME for `detect_src_and_out` due to a failing assertion on native Windows (opened rust-lang#129188): ``` ---- core::config::tests::detect_src_and_out stdout ---- thread 'core::config::tests::detect_src_and_out' panicked at src\core\config\tests.rs:72:13: assertion `left == right` failed left: "E:\\tmp" right: "C:\\tmp" ``` Fixes rust-lang#112544 (because now we handle Windows symlinks properly). try-job: x86_64-msvc try-job: i686-mingw try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: aarch64-gnu
Configuration menu - View commit details
-
Copy full SHA for d4cf9f0 - Browse repository at this point
Copy the full SHA d4cf9f0View commit details -
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs Fixes rust-lang#129163 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
Configuration menu - View commit details
-
Copy full SHA for acc9752 - Browse repository at this point
Copy the full SHA acc9752View commit details -
Rollup merge of rust-lang#129231 - onur-ozkan:improve-submodule-updat…
…es, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787
Configuration menu - View commit details
-
Copy full SHA for c7efc95 - Browse repository at this point
Copy the full SHA c7efc95View commit details -
Rollup merge of rust-lang#129284 - notriddle:notriddle/animate-target…
…=light, r=GuillaumeGomez rustdoc: animate the `:target` highlight This approach is, roughly, based on how Discourse does it. It came up while discussing [some other possible sidebar changes](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/Moving.20deprecated.20items.20out.20of.20the.20way), as a design that made rapid scanning easier while avoiding the inherent trade-offs in summarizing. https://github.com/user-attachments/assets/f7a8fec3-70a5-40a1-92ea-bfdffbd61c22
Configuration menu - View commit details
-
Copy full SHA for a65e367 - Browse repository at this point
Copy the full SHA a65e367View commit details