-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #129126
Rollup of 8 pull requests #129126
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b368dcb - Browse repository at this point
Copy the full SHA b368dcbView commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 55e9810 - Browse repository at this point
Copy the full SHA 55e9810View commit details -
mark
rust-lld-compress-debug-sections
test as needing zstdalso make it fail if there's a compression issue
Configuration menu - View commit details
-
Copy full SHA for c5d9110 - Browse repository at this point
Copy the full SHA c5d9110View commit details -
make
compressed-debuginfo
test about zlib onlyzlib is seemingly always enabled, so we can test it unconditionally
Configuration menu - View commit details
-
Copy full SHA for 2d4af9f - Browse repository at this point
Copy the full SHA 2d4af9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bcbfdb - Browse repository at this point
Copy the full SHA 2bcbfdbView commit details -
expand zstd debuginfo compression test
it now checks zlib and zstd, via rustc and rust-lld
Configuration menu - View commit details
-
Copy full SHA for 0728264 - Browse repository at this point
Copy the full SHA 0728264View commit details -
move it where it's used, and name it like the other scripts
Configuration menu - View commit details
-
Copy full SHA for e42e5c2 - Browse repository at this point
Copy the full SHA e42e5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 323bcdc - Browse repository at this point
Copy the full SHA 323bcdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f27f3a3 - Browse repository at this point
Copy the full SHA f27f3a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e1d839 - Browse repository at this point
Copy the full SHA 1e1d839View commit details -
Configuration menu - View commit details
-
Copy full SHA for f264e5d - Browse repository at this point
Copy the full SHA f264e5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb84372 - Browse repository at this point
Copy the full SHA bb84372View commit details -
Infer async closure args from Fn bound even if there is no correspond…
…ing Future bound
Configuration menu - View commit details
-
Copy full SHA for 4290943 - Browse repository at this point
Copy the full SHA 4290943View commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9028b53 - Browse repository at this point
Copy the full SHA 9028b53View commit details -
Configuration menu - View commit details
-
Copy full SHA for a19a8f8 - Browse repository at this point
Copy the full SHA a19a8f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d562a4a - Browse repository at this point
Copy the full SHA d562a4aView commit details -
Rollup merge of rust-lang#128348 - dingxiangfei2009:allow-shadow-call…
…-stack-sanitizer, r=tmandry Unconditionally allow shadow call-stack sanitizer for AArch64 It is possible to do so whenever `-Z fixed-x18` is applied. cc `@Darksonn` for context The reasoning is that, as soon as reservation on `x18` is forced through the flag `fixed-x18`, on AArch64 the option to instrument with [Shadow Call Stack sanitizer](https://clang.llvm.org/docs/ShadowCallStack.html) is then applicable regardless of the target configuration. At the every least, we would like to relax the restriction on specifically `aarch64-unknonw-none`. For this option, we can include a documentation change saying that users of compiled objects need to ensure that they are linked to runtime with Shadow Call Stack instrumentation support. Related: rust-lang#121972
Configuration menu - View commit details
-
Copy full SHA for 64ef806 - Browse repository at this point
Copy the full SHA 64ef806View commit details -
Rollup merge of rust-lang#128922 - Nadrieril:r-a-use-upstream-pat-ana…
…, r=Veykril rust-analyzer: use in-tree `pattern_analysis` crate r? `@Veykril`
Configuration menu - View commit details
-
Copy full SHA for 41b7f98 - Browse repository at this point
Copy the full SHA 41b7f98View commit details -
Rollup merge of rust-lang#128935 - lqd:needs-zstd, r=Kobzol
More work on `zstd` compression r? `@Kobzol` as we've discussed this. This is a draft to show the current approach of supporting zstd in compiletest, and making the tests using it unconditional. Knowing whether llvm/lld was built with `LLVM_ENABLE_ZSTD` is quite hard, so there are two strategies. There are details in the code, and we can discuss this approach. Until we know the config used to build CI artifacts, it seems our options are somewhat limited in any case. zlib compression seems always enabled, so we only check this in its dedicated test, allowing the test to ignore errors due to zstd not being supported. The zstd test is made unconditional in what it tests, by relying on `needs-llvm-zstd` to be ignored when `llvm.libzstd` isn't enabled in `config.toml`. try-job: x86_64-gnu
Configuration menu - View commit details
-
Copy full SHA for d8f7b52 - Browse repository at this point
Copy the full SHA d8f7b52View commit details -
Rollup merge of rust-lang#129072 - compiler-errors:more-powerful-asyn…
…c-closure-inference, r=lcnr Infer async closure args from `Fn` bound even if there is no corresponding `Future` bound on return In rust-lang#127482, I implemented the functionality to infer an async closure signature when passed into a function that has `Fn` + `Future` where clauses that look like: ``` fn whatever(callback: F) where F: Fn(Arg) -> Fut, Fut: Future<Output = Out>, ``` However, rust-lang#127781 demonstrates that this is still incomplete to address the cases users care about. So let's not bail when we fail to find a `Future` bound, and try our best to just use the args from the `Fn` bound if we find it. This is *fine* since most users of closures only really care about the *argument* types for inference guidance, since we require the receiver of a `.` method call to be known in order to probe methods. When I experimented with programmatically rewriting `|| async {}` to `async || {}` in rust-lang#127827, this also seems to have fixed ~5000 regressions (probably all coming from usages `TryFuture`/`TryStream` from futures-rs): the [before](rust-lang#127827 (comment)) and [after](rust-lang#127827 (comment)) crater runs. Fixes rust-lang#127781.
Configuration menu - View commit details
-
Copy full SHA for 6467cc9 - Browse repository at this point
Copy the full SHA 6467cc9View commit details -
Rollup merge of rust-lang#129101 - compiler-errors:deref-on-parent-by…
…-ref, r=lcnr Fix projections when parent capture is by-ref but child capture is by-value in the `ByMoveBody` pass This fixes a somewhat strange bug where we build the incorrect MIR in rust-lang#129074. This one is weird, but I don't expect it to actually matter in practice since it almost certainly results in a move error in borrowck. However, let's not ICE. Given the code: ``` #![feature(async_closure)] // NOT copy. struct Ty; fn hello(x: &Ty) { let c = async || { *x; //~^ ERROR cannot move out of `*x` which is behind a shared reference }; } fn main() {} ``` The parent coroutine-closure captures `x: &Ty` by-ref, resulting in an upvar of `&&Ty`. The child coroutine captures `x` by-value, resulting in an upvar of `&Ty`. When constructing the by-move body for the coroutine-closure, we weren't applying an additional deref projection to convert the parent capture into the child capture, resulting in an type error in assignment, which is a validation ICE. As I said above, this only occurs (AFAICT) in code that eventually results in an error, because it is only triggered by HIR that attempts to move a non-copy value out of a ref. This doesn't occur if `Ty` is `Copy`, since we'd instead capture `x` by-ref in the child coroutine. Fixes rust-lang#129074
Configuration menu - View commit details
-
Copy full SHA for 8832e00 - Browse repository at this point
Copy the full SHA 8832e00View commit details -
Rollup merge of rust-lang#129106 - compiler-errors:unused-type-ops, r…
…=jieyouxu Remove redundant type ops: `Eq`/`Subtype` r? lcnr or anyone really
Configuration menu - View commit details
-
Copy full SHA for ce5775c - Browse repository at this point
Copy the full SHA ce5775cView commit details -
Rollup merge of rust-lang#129122 - GuillaumeGomez:remove-duplicated-r…
…ustdoc-output-methods, r=Kobzol Remove duplicated `Rustdoc::output` method from `run-make-support` lib I discovered recently that `--output` is deprecated in rustdoc and that `--out-dir` is doing the exact same thing. To keep things along with the current rustdoc status, I removed the `Rustdoc::output` method. cc `@jieyouxu` r? `@Kobzol`
Configuration menu - View commit details
-
Copy full SHA for efb59ed - Browse repository at this point
Copy the full SHA efb59edView commit details -
Rollup merge of rust-lang#129124 - aDotInTheVoid:rdj-hashmap-3, r=Gui…
…llaumeGomez rustdoc-json: Use FxHashMap from rustdoc_json_types Alternative to rust-lang#110051 and rust-lang#127456. This lets us avoid rehashing the json index after building it by using the same hashmap type in construction and in rustdoc_json_types. The above PR's tried to do this by having rustdoc_json_types get the same hashmap that rustdoc has via rustc_data_structures. However, this can be made simpler if we change rustdoc instead. For the rustdoc-type republish on crates.io, It will filter out the `pub use`, and not change source at all. rust-lang/rustdoc-types#30. That code [already replaces the hashmap](https://github.com/aDotInTheVoid/rustdoc-types/blob/8d6528669ec64c2af43d1c79a228b7711cefdad7/update.sh#L11) to use the one in `std::collections` (instead of `FxHashMap`) try-job: dist-arm-linux r? `@GuillaumeGomez`
Configuration menu - View commit details
-
Copy full SHA for 38c9f38 - Browse repository at this point
Copy the full SHA 38c9f38View commit details