Use insertvalue and extractvalue instead of memcpy in CastTarget

[DianQK]

r? @nikic

[DianQK]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 448885c with merge dba68d9...

[bors]

☀️ Try build successful - checks-actions
Build commit: dba68d9 (dba68d9b1f9d17e28d3fde946dac3bfefd4f8f5b)

[rust-timer]

Finished benchmarking commit (dba68d9): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	4
Improvements ✅ (secondary)	-0.3%	[-0.8%, -0.2%]	7
All ❌✅ (primary)	-0.3%	[-0.3%, -0.2%]	4

Max RSS (memory usage)

Results (primary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	10
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	23
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	-0.0%	[-0.1%, 0.1%]	33

Bootstrap: 757.742s -> 756.575s (-0.15%)
Artifact size: 339.25 MiB -> 339.24 MiB (-0.00%)

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[DianQK]

Undefined behavior: Buffer overflow                                     
store i64 %2, ptr %3, align 2

@rustbot author

[DianQK]

I believe the PR is far from being ready for review. The main problem is the incorrect implementation of the cast. In addition to using insertvalue and extractvalue, I also need to handle type conversion here and remove the scratch temporary variable.

I'm not sure whether I should perform a complete conversion like SROA does, or if I should just truncate/convert the final value? Do you have any suggestions? @nikic

Additionally, I think I could revert the implementation in compiler/rustc_codegen_ssa/src/traits/abi.rs to use memcpy, and then handle the type conversion in the next PR.

[rust-log-analyzer]

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:20d3b4d4a2629cbf7865cdbf92fe47512a7c96658c24253a045ff38e8075cd7fb37ca6fcadfa6e6d093333943ad24f6fc4f163ec5b74fd940de9d5bb03eb4d3b:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
failures:

---- [assembly] tests/assembly/powerpc64-struct-abi.rs#elfv2-be stdout ----

error in revision `elfv2-be`: compilation failed!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/assembly/powerpc64-struct-abi.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--cfg" "elfv2_be" "--check-cfg" "cfg(FALSE,elfv1_be,elfv2_be,elfv2_le)" "-O" "-Cdebug-assertions=no" "--emit" "asm" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv2-be/powerpc64-struct-abi.s" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv2-be/auxiliary" "-O" "-Zlint-llvm-ir" "-Cllvm-args=-lint-abort-on-error" "--target" "powerpc64-unknown-linux-musl"
--- stderr -------------------------------
--- stderr -------------------------------
rustc -Cllvm-args="..." with: Unknown command line argument '-lint-abort-on-error'.  Try: 'rustc -Cllvm-args="..." with --help'
rustc -Cllvm-args="..." with: Did you mean '--start-after'?


---- [assembly] tests/assembly/powerpc64-struct-abi.rs#elfv1-be stdout ----


error in revision `elfv1-be`: compilation failed!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/assembly/powerpc64-struct-abi.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--cfg" "elfv1_be" "--check-cfg" "cfg(FALSE,elfv1_be,elfv2_be,elfv2_le)" "-O" "-Cdebug-assertions=no" "--emit" "asm" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv1-be/powerpc64-struct-abi.s" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv1-be/auxiliary" "-O" "-Zlint-llvm-ir" "-Cllvm-args=-lint-abort-on-error" "--target" "powerpc64-unknown-linux-gnu"
--- stderr -------------------------------
--- stderr -------------------------------
rustc -Cllvm-args="..." with: Unknown command line argument '-lint-abort-on-error'.  Try: 'rustc -Cllvm-args="..." with --help'
rustc -Cllvm-args="..." with: Did you mean '--start-after'?


---- [assembly] tests/assembly/powerpc64-struct-abi.rs#elfv2-le stdout ----


error in revision `elfv2-le`: compilation failed!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/assembly/powerpc64-struct-abi.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--cfg" "elfv2_le" "--check-cfg" "cfg(FALSE,elfv1_be,elfv2_be,elfv2_le)" "-O" "-Cdebug-assertions=no" "--emit" "asm" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv2-le/powerpc64-struct-abi.s" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly/powerpc64-struct-abi.elfv2-le/auxiliary" "-O" "-Zlint-llvm-ir" "-Cllvm-args=-lint-abort-on-error" "--target" "powerpc64le-unknown-linux-gnu"
--- stderr -------------------------------
--- stderr -------------------------------
rustc -Cllvm-args="..." with: Unknown command line argument '-lint-abort-on-error'.  Try: 'rustc -Cllvm-args="..." with --help'
rustc -Cllvm-args="..." with: Did you mean '--start-after'?



failures:

[bors]

☔ The latest upstream changes (presumably #130473) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@DianQK any updates on this? thanks

[DianQK]

@DianQK any updates on this? thanks

I'm low on the priority list for this PR. :)

[DianQK]

When I rework on this PR, I'll split it into two separate PRs.