Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jump threading of float equality #128271

Commits on Jul 27, 2024

  1. Disable jump threading of float equality

    Jump threading stores values as `u128` (`ScalarInt`) and does its
    comparisons for equality as integer comparisons.
    This works great for integers. Sadly, not everything is an integer.
    
    Floats famously have wonky equality semantcs, with `NaN!=NaN` and
    `0.0 == -0.0`. This does not match our beautiful integer bitpattern
    equality and therefore causes things to go horribly wrong.
    
    While jump threading could be extended to support floats by remembering
    that they're floats in the value state and handling them properly,
    it's signficantly easier to just disable it for now.
    Noratrieb committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    f305e18 View commit details
    Browse the repository at this point in the history