Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bootstrap compiler to the new beta #128216

Closed
wants to merge 4 commits into from
Closed

Bump bootstrap compiler to the new beta #128216

wants to merge 4 commits into from

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 26, 2024 •
edited
Loading

Cherry pick the changes from #128083, update the bump to the latest bootstrap that includes the backport #128167, and fix a UI test.

Either #128083 can be updated or this can be merged, no difference.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2024

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@tgross35 tgross35 changed the title Bump bootstrap compiler to the new beta [test] Bump bootstrap compiler to the new beta Jul 26, 2024
@tgross35
Copy link
Contributor Author

r? @ghost

@rustbot

This comment was marked as outdated.

Sign in to view
@tgross35 tgross35 marked this pull request as draft July 26, 2024 01:58
@tgross35
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2024
@bors
Auto merge of rust-lang#128216 - tgross35:bump-stage0, r=<try>
f63ce3a 
[test] Bump bootstrap compiler to the new beta
@bors
Copy link
Contributor

bors commented Jul 26, 2024

⌛ Trying commit 8750694 with merge f63ce3a...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor Author

@bors try-

@tgross35
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2024
@tgross35
Copy link
Contributor Author

Seems like canceling a try job requires a special incantation.

@bors try
@rustbot author

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 26, 2024
@bors
Copy link
Contributor

bors commented Jul 26, 2024

⌛ Trying commit d4bdbad with merge 69ed69b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2024
@bors
Auto merge of rust-lang#128216 - tgross35:bump-stage0, r=<try>
69ed69b 
[test] Bump bootstrap compiler to the new beta
@jieyouxu
Copy link
Member

Seems like canceling a try job requires a special incantation.

AFAIK you can't cancel try jobs.

@tgross35 tgross35 changed the title [test] Bump bootstrap compiler to the new beta Bump bootstrap compiler to the new beta Jul 26, 2024
@tgross35 tgross35 marked this pull request as ready for review July 26, 2024 04:00
@bors
Copy link
Contributor

bors commented Jul 26, 2024

☀️ Try build successful - checks-actions
Build commit: 69ed69b (69ed69b427b28cbc32ce511c65d4a42882fa9c34)

@tgross35 tgross35 closed this Jul 26, 2024
This was referenced Jul 29, 2024
Merged
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2024
@bors
Auto merge of rust-lang#128326 - tgross35:bump-stage0-test1, r=<try>
6854cec 
[experiment] stage0 bump: test reverting bootstrap changes

rust-lang#128083 failed with a stage0/stage1 mismatch. Try reverting rust-lang#127799 since it is the only thing that touched bootstrap since the last known success at rust-lang#128216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tgross35 @rustbot @bors @rust-log-analyzer @jieyouxu @onur-ozkan @Mark-Simulacrum