Allow to pass a full path for run-make tests
#128100
Conversation
rustbot
added
A-testsuite
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
Oh yeah I've been annoyed by this as well, nice! |
|
I like the idea, but I'm a bit scared of making compiletest changes unnecessarily. Could this be implemented via the inverse logic, i.e. if we get a |
|
I went for that originally. That means updating the filters, iterate over them and for each of them, check if the path starts with |
|
Oh, if you specify a filepath, it won't automatically go here? In that case it's not as simple as I thought 😆 But still I probably prefer the directory handling, in my view the test is the directory, and |
|
I think it doesn't do what you think it does. 😆 |
GuillaumeGomez
force-pushed
the
run-make-path
branch
from
baf948d
to
0728c15
Compare
|
I went for the filter update instead. Much simpler, should have gone for this one instead... What do you think of this approach? |
|
I don't know a lot about compiletest, but this looks better than before, and it works for me. I wonder how UI tests do this though. If I do Anyway, feel free to r=me, unless @jieyouxu has any objections. |
|
It's actually |
|
Yeah, rmake.rs not accepting the exact path was just a quirk in my original implementation of it, this part of the test filtering has not been changed since I added it initially. It was more of a "initial working version". |
|
Prototype -> prod, oh well, we all know the drill. 😆 Then let's go! @bors r=Kobzol,jieyouxu rollup |
bors
added
S-waiting-on-bors
The original rmake.rs infra PR failed bors full build like 20 times, im just glad it ever passed lol |
|
You should give a talk or write a blog post about "Migrating run-make, the ugly and terrible" haha |
…bzol,jieyouxu Allow to pass a full path for `run-make` tests It's common (at least for me) to pass a full path to a `run-make` test (including the `rmake.rs` file) and to see that it isn't found, which is a bit frustrating. With these changes, we can now optionally pass the `rmake.rs` (or even `Makefile`) at the end of the path. cc `@jieyouxu` r? `@Kobzol`
…bzol,jieyouxu Allow to pass a full path for `run-make` tests It's common (at least for me) to pass a full path to a `run-make` test (including the `rmake.rs` file) and to see that it isn't found, which is a bit frustrating. With these changes, we can now optionally pass the `rmake.rs` (or even `Makefile`) at the end of the path. cc ``@jieyouxu`` r? ``@Kobzol``
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124895 (Disallow hidden references to mutable static) - rust-lang#128043 (Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core") - rust-lang#128092 (Remove wrapper functions from c.rs) - rust-lang#128100 (Allow to pass a full path for `run-make` tests) - rust-lang#128106 (Fix return type of FileAttr methods on AIX target) - rust-lang#128108 (ensure std step before preparing sysroot) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125962 (Update tracking issue for `const_binary_heap_new_in`) - rust-lang#126770 (Add elem_offset and related methods) - rust-lang#127481 (Remove generic lifetime parameter of trait `Pattern`) - rust-lang#128043 (Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core") - rust-lang#128092 (Remove wrapper functions from c.rs) - rust-lang#128100 (Allow to pass a full path for `run-make` tests) - rust-lang#128106 (Fix return type of FileAttr methods on AIX target) - rust-lang#128108 (ensure std step before preparing sysroot) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128100 - GuillaumeGomez:run-make-path, r=Kobzol,jieyouxu Allow to pass a full path for `run-make` tests It's common (at least for me) to pass a full path to a `run-make` test (including the `rmake.rs` file) and to see that it isn't found, which is a bit frustrating. With these changes, we can now optionally pass the `rmake.rs` (or even `Makefile`) at the end of the path. cc ```@jieyouxu``` r? ```@Kobzol```
It's common (at least for me) to pass a full path to a
run-maketest (including thermake.rsfile) and to see that it isn't found, which is a bit frustrating.With these changes, we can now optionally pass the
rmake.rs(or evenMakefile) at the end of the path.cc @jieyouxu
r? @Kobzol