-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename std::vec -> std::slice #12772
Conversation
I'd like to discuss this before merging so we can ensure that this is the direction that we want to go in. |
I'm in favour of this. Have |
I would imagine that an import from |
At first I expected the module this PR calls |
👍 |
related issues of mozilla/rust: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
related issues of mozilla/rust: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
related issues of mozilla/rust: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust@0305ed5 std: Add Vec to the prelude - rust-lang/rust#12935 Disallow trailing parentheses for nullary enum variants
related issues of mozilla/rust: - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude already fixed in chris-morgan#69: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
related issues of mozilla/rust: - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude already fixed in chris-morgan#69: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
internal: Remove allocation in DefCollector::reseed_with_unresolved_attribute
…, r=y21 add lint for recreation of an entire struct This lint makes Clippy warn about situations where an owned struct is essentially recreated by moving all its fields into a new instance of the struct. The lint is not machine-applicable because the source struct may have been partially moved. This lint originated in something I spotted during peer review. While working on their branch a colleague ended up with a commit where a function returned a struct that 1:1 replicated one of its owned inputs from its members. Initially I suspected they hadn’t run their code through Clippy but AFAICS there is no lint for this situation yet. changelog: new lint: [`redundant_owned_struct_recreation`] ### New lint checklist - \[+] Followed [lint naming conventions][lint_naming] - \[+] Added passing UI tests (including committed `.stderr` file) - \[+] `cargo test` passes locally - \[+] Executed `cargo dev update_lints` - \[+] Added lint documentation - \[+] Run `cargo dev fmt`
Closes #12702