-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tidy problematic const checking fast again #127455
Conversation
This reverts commit 8d85043. The regexes are important for performance.
rustbot has assigned @Mark-Simulacrum. Use |
@bors p=1 |
@bors r+ |
@bors p=10 let's jump ahead of the rollup |
@bors retry hello, bump |
☀️ Test successful - checks-actions |
Finished benchmarking commit (959a2eb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.9%, secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 699.903s -> 699.476s (-0.06%) |
fixes pathological tidy performance described in #127453 by reverting #127428
i think anyone can approve this ASAP, it makes working on this repo significantly worse.