Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Set has_reliable_f16 to false for MIPS targets in build.rs #127235

Merged
merged 3 commits into from
Jul 8, 2024
Merged

std: Set has_reliable_f16 to false for MIPS targets in build.rs #127235

merged 3 commits into from
Jul 8, 2024

Commits on Jul 3, 2024

  1. library/std/build.rs: "powerpc64le" is not a target_arch 

    The target_arch of `powerpc64le` is `powerpc64`, so
`powerpc64le` can be removed from a match arm in build.rs
related to f16.

You can check available `target_arch`:s with:

    $ rustc +nightly -Zunstable-options --print all-target-specs-json \
            | grep powerpc | grep arch | sort | uniq
        "arch": "powerpc",
        "arch": "powerpc64",
    Martin Nordholts committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e8df637 View commit details
    Browse the repository at this point in the history

  2. std: Set has_reliable_f16 to false for MIPS targets in build.rs 

    To avoid this linker error:

    $ sudo apt install libc6-mips-cross gcc-mips-linux-gnu
    $ CC_mips_unknown_linux_gnu=mips-linux-gnu-gcc \
      CARGO_TARGET_MIPS_UNKNOWN_LINUX_GNU_LINKER=mips-linux-gnu-gcc \
      ./x test library/std --target mips-unknown-linux-gnu
    undefined reference to `__gnu_f2h_ieee'

You get the same linker error also with mipsel, mips64 and
mips64el toolchains.
    Martin Nordholts committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    310d4ef View commit details
    Browse the repository at this point in the history

  3. core: Limit four f16 doctests to x86_64 linux 

    These tests have link errors on many platforms, so limit
them to only x86_64 linux for now. There are many other f16
non-doctests, so we don't need to run these particular ones
widely.
    Martin Nordholts committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6f9ec57 View commit details
    Browse the repository at this point in the history