Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure out_of_scope_macro_calls lint is registered #127191

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

beetrees
Copy link
Contributor

Fixes part of #126984 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops!

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 1, 2024

📌 Commit 4c919ac has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2024
@BoxyUwU BoxyUwU assigned compiler-errors and unassigned BoxyUwU Jul 1, 2024
@jieyouxu jieyouxu added the L-out_of_scope_macro_calls Lint: out_of_scope_macro_calls label Jul 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 1, 2024
…ro-calls, r=compiler-errors

Ensure `out_of_scope_macro_calls` lint is registered

Fixes part of rust-lang#126984 (comment).
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126923 (test: dont optimize to invalid bitcasts)
 - rust-lang#127090 (Reduce merge conflicts from rustfmt's wrapping)
 - rust-lang#127105 (Only update `Eq` operands in GVN if it can update both sides)
 - rust-lang#127150 (Fix x86_64 code being produced for bare-metal LoongArch targets' `compiler_builtins`)
 - rust-lang#127181 (Introduce a `rustc_` attribute to dump all the `DefId` parents of a `DefId`)
 - rust-lang#127182 (Fix error in documentation for IpAddr::to_canonical and Ipv6Addr::to_canonical)
 - rust-lang#127191 (Ensure `out_of_scope_macro_calls` lint is registered)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5ef1cd into rust-lang:master Jul 1, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024
Rollup merge of rust-lang#127191 - beetrees:register-out-of-scope-macro-calls, r=compiler-errors

Ensure `out_of_scope_macro_calls` lint is registered

Fixes part of rust-lang#126984 (comment).
@rustbot rustbot added this to the 1.81.0 milestone Jul 1, 2024
@beetrees beetrees deleted the register-out-of-scope-macro-calls branch July 1, 2024 13:42
@tgross35
Copy link
Contributor

tgross35 commented Jul 1, 2024

Is there something we could hack up to get an unused or tidy warning when if lints aren't registered anywhere? Seems like an easy mistake to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-out_of_scope_macro_calls Lint: out_of_scope_macro_calls S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants