-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dylib-chain
, rlib-chain
, issue-47384
, msvc-opt-minsize
and test-harness
run-make
tests to ui/rmake
#127044
Conversation
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
95ba6d7
to
2019f15
Compare
Migrate `dylib-chain`, `rlib-chain`, `issue-47384`, `msvc-opt-minsize` and `test-harness` `run-make` tests to ui/rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). `issue-47384` demands a Windows/Apple try-job. try-job: x86_64-msvc try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
2019f15
to
ea53274
Compare
Ignore directive re-added with reason. @rustbot review |
@rustbot author |
ea53274
to
02a5002
Compare
☔ The latest upstream changes (presumably #127121) made this pull request unmergeable. Please resolve the merge conflicts. |
35afb92
to
45313a6
Compare
Did nothing except resolve merge conflict, please re-approve. @rustbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
@bors r=Kobzol,jieyouxu |
☀️ Test successful - checks-actions |
Finished benchmarking commit (aa1d4f6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 4.3%, secondary 2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 742.115s -> 724.291s (-2.40%) |
Part of #121876 and the associated Google Summer of Code project.
try-job: x86_64-msvc
try-job: aarch64-apple