Rollup of 8 pull requests

[matthiaskrgr]

Successful merges:

• Indicate in non_local_defs lint that the macro needs to change #125722 (Indicate in non_local_defs lint that the macro needs to change)
• rustc_span: Add conveniences for working with span formats #125829 (rustc_span: Add conveniences for working with span formats)
• Various Redox OS fixes and add i686 Redox OS target #126192 (Various Redox OS fixes and add i686 Redox OS target)
• ci: Update centos:7 to use vault repos #126352 (ci: Update centos:7 to use vault repos)
• Use Variance glob imported variants everywhere #126354 (Use Variance glob imported variants everywhere)
• MIR Shl/Shr: the offset can be computed with rem_euclid #126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• build libcxx-version only when it doesn't exist #126472 (build libcxx-version only when it doesn't exist)
• Fix running bootstrap tests with a local Rust toolchain as the stage0 #126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=8

[bors]

📌 Commit d97c040 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit d97c040 with merge 93b52c9...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry no logs

[bors]

⌛ Testing commit d97c040 with merge e2f0eac...

[rust-log-analyzer]

The job x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

======================================================================
ERROR: test_cargoflags (bootstrap_test.BuildBootstrap.test_cargoflags)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 175, in test_cargoflags
    args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 172, in build_args
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 172, in build_args
    return build.build_bootstrap_cmd(env), env
  File "C:\a\rust\rust\src\bootstrap\bootstrap.py", line 1005, in build_bootstrap_cmd
  File "C:\a\rust\rust\src\bootstrap\bootstrap.py", line 1005, in build_bootstrap_cmd
    raise Exception("no cargo executable found at `{}`".format(
Exception: no cargo executable found at `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0/bin/cargo`
======================================================================
ERROR: test_warnings (bootstrap_test.BuildBootstrap.test_warnings)
----------------------------------------------------------------------
Traceback (most recent call last):
Traceback (most recent call last):
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 184, in test_warnings
    _, env = self.build_args(configure_args, args=["--warnings=warn"])
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 172, in build_args
  File "C:\a\rust\rust\src\bootstrap\bootstrap_test.py", line 172, in build_args
    return build.build_bootstrap_cmd(env), env
  File "C:\a\rust\rust\src\bootstrap\bootstrap.py", line 1005, in build_bootstrap_cmd
  File "C:\a\rust\rust\src\bootstrap\bootstrap.py", line 1005, in build_bootstrap_cmd
    raise Exception("no cargo executable found at `{}`".format(
Exception: no cargo executable found at `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0/bin/cargo`
----------------------------------------------------------------------
Ran 12 tests in 0.578s

FAILED (errors=2)
---
configure: profile              := dist
configure: build.configure-args := ['--set', 'profile=compiler']
configure: profile              := compiler
Build completed unsuccessfully in 1:19:15
make: *** [Makefile:102: ci-msvc-ps1] Error 1
  network time: Sat, 15 Jun 2024 00:01:59 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions