Honor collapse_debuginfo for statics. #126365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
that works too, nice. |
|
@Dirbaio can this come with a regression test? probably a debuginfo test, specifically? |
|
@workingjubilee done! |
|
Oh, okay. :^) @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 16, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#126178 (Weekly `cargo update`) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126365 (Honor collapse_debuginfo for statics.) - rust-lang#126524 (bump few deps) - rust-lang#126536 (Remove unused `llvm_readobj.rs` in `run-make-support`) - rust-lang#126546 (std: move `sys_common::backtrace` to `sys`) - rust-lang#126560 (more ice tests) - rust-lang#126561 (`boxed_slice_into_iter`: tiny doc correction) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 16, 2024
Rollup merge of rust-lang#126365 - Dirbaio:collapse-debuginfo-statics, r=workingjubilee Honor collapse_debuginfo for statics. fixes rust-lang#126363 <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #126363