Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a bunch of booleans in favor of Result<(), ErrorGuaranteed> as that more robustly proves that an error has been emitted #126317

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Avoid a bunch of booleans in favor of Result<(), ErrorGuaranteed> as that more robustly proves that an error has been emitted #126317

merged 6 commits into from
Jun 12, 2024

Commits on Jun 12, 2024

  1. Bump tracing-tree and allow rendering lines again

    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    185a48d View commit details
    Browse the repository at this point in the history

  2. Avoid a bunch of booleans in favor of Result<(), ErrorGuaranteed> a… 

    …s that more robustly proves that an error has been emitted
    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3da9289 View commit details
    Browse the repository at this point in the history

  3. Upgrade a span_delayed_bug into a span_bug, as we have no tests hitti… 

    …ng it.
    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    be464b8 View commit details
    Browse the repository at this point in the history

  4. Eagerly emit the diagnostic instead of leaving it to all callers

    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4d72c42 View commit details
    Browse the repository at this point in the history

  5. Rename some functions

    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9065889 View commit details
    Browse the repository at this point in the history

  6. Avoid a Ty::new_misc_error when an ErrorGuaranteed is available

    @oli-obk
    oli-obk committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6299071 View commit details
    Browse the repository at this point in the history