Crate loader cleanups #126099
Merged
Crate loader cleanups #126099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the path operation with `join`, clarify some of the names.
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
jieyouxu
approved these changes
Jun 6, 2024
Comment on lines
+417
to
+419
| let (hash, kind) = if let Some(f) = f.strip_prefix(rlib_prefix) | ||
| && let Some(f) = f.strip_suffix(rlib_suffix) | ||
| { |
There was a problem hiding this comment.
This is much easier to understand 👍
There was a problem hiding this comment.
i really love rusts string manipulation methods
| } else { | ||
| sess.target_filesearch(path_kind) | ||
| }, | ||
| target: &sess.target, |
There was a problem hiding this comment.
I'm so confused. The callsite is always false and there was a casual is_host branch here? Archaeology didn't reveal much for why this came to be, oh well.
There was a problem hiding this comment.
But apparently this seems to work since 5 years ago when is_host was introduced, then I guess it must've worked because nobody complained about it 🤷
There was a problem hiding this comment.
Only true usage in https://github.com/rust-lang/rust/pull/66496/files
/// Look for a plugin registrar. Returns its library path and crate disambiguator.
pub fn find_plugin_registrar(so I think this is correct since we ripped out compiler plugin support some time ago.
|
since I'm going to sleep and won't be here for CI to complete, I'll optimistically |
bors
added
S-waiting-on-bors
|
jokes on me i didn't go to sleep and got to witness green CI, fuck |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 7, 2024
…=jieyouxu Crate loader cleanups Minor cleanups I found while trying to understand how all of this works
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#125606 (Size optimize int formatting) - rust-lang#125724 (Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver`) - rust-lang#126040 (Don't warn on fields in the `unreachable_pub` lint ) - rust-lang#126065 (mark binding undetermined if target name exist and not obtained) - rust-lang#126098 (Remove `same-lib-two-locations-no-panic` run-make test) - rust-lang#126099 (Crate loader cleanups) - rust-lang#126101 (Revert "Disallow ambiguous attributes on expressions" on nightly) - rust-lang#126103 (Improve Docs for `hir::Impl` and `hir::ImplItem`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#125606 (Size optimize int formatting) - rust-lang#125724 (Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver`) - rust-lang#126040 (Don't warn on fields in the `unreachable_pub` lint ) - rust-lang#126098 (Remove `same-lib-two-locations-no-panic` run-make test) - rust-lang#126099 (Crate loader cleanups) - rust-lang#126101 (Revert "Disallow ambiguous attributes on expressions" on nightly) - rust-lang#126103 (Improve Docs for `hir::Impl` and `hir::ImplItem`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
Rollup merge of rust-lang#126099 - Nilstrieb:crate-loader-cleanups, r=jieyouxu Crate loader cleanups Minor cleanups I found while trying to understand how all of this works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups I found while trying to understand how all of this works