Remove some obsolete ignored tests #12476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* compile-fail/vec-add.rs is obsolete, there are no mutable vectors any more, rust-lang#2711 is closed * compile-fail/issue-1451.rs is obsolete, there are no more structural records, rust-lang#1451 is closed * compile-fail/issue-2074.rs is obsolete, an up to date test is in run-pass/nested-enum-same-names.rs, rust-lang#2074 is closed * compile-fail/omitted-arg-wrong-types.rs is obsolete, rust-lang#2093 is closed
|
This may conflict with #12457 a bit, but I'll let bors figure it out. |
|
It seems like your cleanup was way more extensive ;) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Restart server automatically on settings changes Closes rust-lang#12476 I think this works quite well, but if you think it would be better to put it behind a setting I can do that.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 5, 2024
…check, r=y21 Extend `implicit_saturating_sub` lint Fixes rust-lang#10070. It can serve as base if we want to add equivalent checks for other arithmetic operations. Also one important note: when writing this lint, I realized that I could check for wrong conditions performed beforehand on subtraction and added another part in the lint. Considering they both rely on the same checks, I kept both in the same place. Not sure if it makes sense though... changelog: Extend `implicit_saturating_sub` lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes 4 obsolete ignored test cases
vectors any more, Fix vec-add #2711 is closed
structural records, bare fn types in record unification produces unexpected errors #1451 is closed
is in run-pass/nested-enum-same-names.rs, duplicate symbols with enum in boxed closure #2074 is closed
is closed